Changes between Initial Version and Version 1 of Ticket #3727, comment 17


Ignore:
Timestamp:
11/18/16 07:21:10 (8 years ago)
Author:
boruch
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #3727, comment 17

    initial v1  
    55Only because my background isn't with GNOME and Glib. 
    66 
     7---- 
    78 
    89> src_filemanager_usermenu.c.diff 
    … …  
    1415That's just me and a readability coding convention from prior employment / projects. 
    1516 
     17---- 
    1618 
    1719> You use nested functions in this patch. Please don't. This is GCC extension and invalid standard C code. 
    … …  
    1921Agreed. I may have noted in the code that it was meant to be temporary, and suggested that the function be moved to its own source code file. 
    2022 
     23---- 
     24 
    2125Also, in a parallel comment on this ticket, I'm discussing the TRAVIS build system with zaytzev. These nested functions were not objected to by TRAVIS, so maybe in addition to what I'm suggesting to zaytsev, the compiler variables should address this. 
    2226 
     27---- 
     28 
    2329Also, please remember that this part of the patch, ie. the changes to usermenu.c aren't really part of this ticket, because its unrelated to the info box. I included it to maintain parallelism with the github pull request which went so wrong. One of the things that went wrong there was that when I thought I was staging a second pull request (related to usermenu parsing), it was just added to this prior pull request.