Ticket #372 (closed defect: fixed)

Opened 10 years ago

Last modified 9 years ago

user menu ignores entries

Reported by: ossi Owned by: iNode
Priority: major Milestone: 4.7.0-pre1
Component: mc-core Version: master
Keywords: commited-master Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description

the user menu (the one under f2 in the main panel view) ignores some (but not all) of my menu entries.

from the attached file, for example the various 'p' bindings are missing.

Attachments

menu (9.3 KB) - added by ossi 10 years ago.
~/.mc/menu
usermenu_regex.patch (1.1 KB) - added by iNode 10 years ago.
enable regex matching in user menu on shell_patterns=0

Change History

Changed 10 years ago by ossi

~/.mc/menu

comment:1 follow-up: ↓ 2 Changed 10 years ago by iNode

Menu entries does not ignored it's simple does not match.

I review your "p" menu entries:

1) escape of "." seems to be useless in that case
2) ".." matched by "+ f .." (also it match "..test" and "test.."), "" and "$" - does not mean start and end of line in that case
3).(mp3|ogg) - does not match, when .mp3 - match

We has no doc or examples for work in shell_patterns=0 mode.
So, we should define that mode before try make it work appropriately.

comment:2 in reply to: ↑ 1 Changed 10 years ago by ossi

Replying to iNode:

Menu entries does not ignored it's simple does not match.

that is true for the "+ t t" entry.

I review your "p" menu entries:

1) escape of "." seems to be useless in that case

wrong. this is a regex, so to match a literal dot, it must be escaped.

2) ".." matched by "+ f .." (also it match "..test" and "test.."), "" and "$" - does not mean start and end of line in that case

wrong again ...

3).(mp3|ogg) - does not match, when .mp3 - match

huh?

We has no doc or examples for work in shell_patterns=0 mode.
So, we should define that mode before try make it work appropriately.

well, frankly, i don't care - it worked for the last 5+ years and "you" broke it. ;)

comment:3 Changed 10 years ago by iNode

well, frankly, i don't care - it worked for the last 5+ years and "you" broke it. ;)

OK. That's good start point. :)
What the last version where it work correctly?

Changed 10 years ago by iNode

enable regex matching in user menu on shell_patterns=0

comment:4 Changed 10 years ago by iNode

  • Status changed from new to accepted
  • Owner set to iNode

Please, try this patch.

All should be work except "\.\.$" regex.

If it's ok we need to create new ticket to fix "\.\.$" matching,
because it's other issue.

comment:5 Changed 10 years ago by angel_il

branch: 372_usermenu_regex (parent: master)
changeset: 098e0a4254eea2987072460223d4a7dc3e1b519a
owner: INode

comment:6 Changed 10 years ago by angel_il

  • Keywords review vote-angel_il added

my vote here

comment:7 Changed 10 years ago by slyfox

  • Keywords review vote-angel_il removed

comment:8 Changed 10 years ago by slyfox

  • Keywords review vote-angel_il added

Sorry. returning keywords

comment:9 Changed 10 years ago by slavazanko

  • Keywords vote-slavazanko approved added; review removed
  • Blocked By 419 added

comment:10 Changed 10 years ago by angel_il

  • Milestone changed from 4.7 to 4.7.0-pre1

comment:11 Changed 10 years ago by slavazanko

  • Blocked By 419 removed

comment:12 Changed 10 years ago by angel_il

  • Keywords commited-master added; vote-angel_il vote-slavazanko approved removed
  • Status changed from accepted to testing
  • Resolution set to fixed

comment:13 Changed 10 years ago by angel_il

  • Status changed from testing to closed

comment:14 Changed 10 years ago by sunrise1

  • severity set to no branch
Note: See TracTickets for help on using tickets.