Ticket #3671 (closed defect: invalid)

Opened 3 years ago

Last modified 3 years ago

RFC: when built against netbsd-curses, "rotating wheel" animation overwrites column headers

Reported by: foobarbaz Owned by:
Priority: trivial Milestone:
Component: mc-tty Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: no branch Votes for changeset:

Description

unlike when built against ncurses, whenever there's things we have to wait for (for example changing dirs on an ftp connection), there's a "rotating wheel" ascii animation, however it moves across the screen instead of spinning in one place.
the animation consists of the characters \|/- and results in the following pattern being drawn over the column headers of the panels:

\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-

to fix it, please provide me the following information

  • where in the code this graphic gets drawn (i couldn't find it)
  • and where it's supposed to be drawn to (in the version built against ncurses i couldnt spot it at all).

thanks!

Change History

comment:1 in reply to: ↑ description Changed 3 years ago by andrew_b

Replying to foobarbaz:

  • where in the code this graphic gets drawn (i couldn't find it)

rotate_dash() in src/filemanager/layout.c (and also find_rotate_dash() in src/filemanager/find.c for find file results).

  • and where it's supposed to be drawn to (in the version built against ncurses i couldnt spot it at all).

The rotating dash is drawn in top-right corner.

comment:2 Changed 3 years ago by andrew_b

  • Version set to master
  • Milestone set to Future Releases

comment:3 Changed 3 years ago by egmont

Sounds to me like probably a bug in netbsd-curses.

comment:4 Changed 3 years ago by foobarbaz

comment:5 Changed 3 years ago by foobarbaz

i forgot to mention that the reason why i couldn't see this animation in the ncurses version at all is
because the code that makes the FTP connection, which is actually the slow thing, does not update the animation. it seems to be only called when the directory list is printed, which seems to happen so fast that the animation is not visible.

comment:6 Changed 3 years ago by andrew_b

  • Component changed from mc-core to mc-tty

So? Close as 'invalid'?

comment:7 follow-up: ↓ 8 Changed 3 years ago by foobarbaz

i'd like to but there's no button to do so, probably because i opened this as "task", not as bug.

comment:8 in reply to: ↑ 7 Changed 3 years ago by andrew_b

  • Status changed from new to closed
  • Resolution set to invalid
  • Type changed from task to defect
  • Milestone Future Releases deleted

Replying to foobarbaz:

i'd like to

OK.

but there's no button to do so, probably because i opened this as "task", not as bug.

No. You just don't have permission to close ticket.

Note: See TracTickets for help on using tickets.