Ticket #3665 (closed defect: fixed)

Opened 8 years ago

Last modified 8 years ago

lib/tty/tty_ncurses.c accesses internal data structures, breaks compilation with NetBSD curses

Reported by: foobarbaz Owned by: andrew_b
Priority: minor Milestone: 4.8.18
Component: mc-tty Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

The code that manipulates the ncurses backend into changing the key combination to generate SIGINT from CTRL-c to CTRL-g does so by accessing undocumented internal ncurses data structures.
This breaks compilation with netbsd-curses[0], and could also break when the ncurses author decides to change internal structures in a future release.

patch was submitted: ​https://github.com/MidnightCommander/mc/pull/108

Change History

comment:2 Changed 8 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Milestone changed from Future Releases to 4.8.18

Branch: 3665_netbsd_curses
changeset:38d4c655d322837574e957b4a824f4a0d1bb3b86

comment:3 Changed 8 years ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from no branch to approved

comment:4 Changed 8 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [3265531907da3660ce6e080aa1770fe9d12a3172].

comment:5 Changed 8 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.