Changes between Initial Version and Version 1 of Ticket #3664, comment 19


Ignore:
Timestamp:
08/23/16 12:57:18 (5 years ago)
Author:
mooffie
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3664, comment 19

    initial v1  
    77What we're dealing with is ''key bindings'', not ''actions''. It's certain **key bindings** that we want to limit to "the command line is empty" condition. 
    88 
    9 As for Select / Unselect / SelectInvert from [main]: they're actually bound to the `+ - *` keys of the **keypad**, not to the ASCII keys, so they work for non-empty command lines as well (BTW, we can also invoke them using the menu; so, again, we see that the actions themselves don't care about the status of the command line). The `+ - *` **ASCII** keys, OTOH, aren't bound using any keymap: they're hardcoded in MSG_KEY of midnight_callback() (and the purpose of this ticket is to get rid of **this** hardcoding). 
     9As for Select / Unselect / SelectInvert from [main]: they're actually bound to the `+ - *` keys of the **keypad**, not to the ASCII keys, so they work for non-empty command lines as well (BTW, we can also invoke them using the menu; so, again, we see that the actions themselves don't care about the status of the command line). The `+ - *` **ASCII** keys, OTOH, aren't bound using any keymap: they're hardcoded in MSG_KEY of midnight_callback() (and the purpose of this ticket is to get rid of **this** hardcoding; the [main] keymap is fine: there's nothing to fix in it). 
    1010  
    1111> I think, the 'empty commandline mode' is default mode. 90% actions are made with empty command line.