Panelize resets marks on marked files in many cases when it should not

[avallac_h]

This happens after:

• hiding panels with Ctrl-o
• refreshing Panelize panel with Ctrl-r
• launching an editor (no matter internal or external)
• launching an external viewer
• executing any shell command
• performing any operation on opposite panel (copy, rename, link creation. etc.)
• copying files from Panelize panel and choosing 'Don't overwrite' files on the opposite panel.

The last one is the most annoying: it leads to the situation when not all marked files have been copied, but you'll never find what files you are missing 'cause you've already loose everything you marked.

Steps to reproduce:

1. Search files with any criteria using 'Find file'
2. Select [Panelize]
3. Mark some files with Ins or Ctrl-t
4. Do anything mentioned from above

P.S. As for me, it seems that all of these cases can be bundled together because all mentioned operations call a 'do_refresh ()' function.

[mooffie]

Here's a patch (two, actually).

Patch "v1" is how I initially thought to fix this. It's easy to see the cause of the bug here (do_file_mark(), at some point in history after that code was written, was modified to assign to f.marked).

But when we examine how non-panelized panels reload, we see that they use recalculate_panel_summary(), and there's no reason not to choose this solution for panelized panels as well. That's patch "v2".

In short: use v2, not v1. (Although both work.)

[andrew_b]

Replying to mooffie:

In short: use v2

Thanks!

Branch: 3663_panelize_keep_marked
changeset:d6aa2ff92411e7154088123904c535d3bcdd3f08

[andrew_b]

Merged to master: [837a21009ed843490f8820ebe7d0e15252ad39f0].