Ticket #3643 (closed defect: fixed)

Opened 9 years ago

Last modified 9 years ago

mc-4.8.17 failing to build on FreeBSD

Reported by: woodsb02 Owned by: zaytsev
Priority: major Milestone: 4.8.18
Component: mc-core Version: 4.8.17
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

The latest release of mc 4.8.17 fails to build on FreeBSD with the following error:

  CCLD     mc
./.libs/libinternal.a(cons.handler.o): In function `show_console_contents':
cons.handler.c:(.text+0x98): undefined reference to `min'
cons.handler.c:(.text+0xde): undefined reference to `min'
cc: error: linker command failed with exit code 1 (use -v to see invocation)
Makefile:658: recipe for target 'mc' failed

Attachments

mc-4.8.17.log​ (110.0 KB) - added by woodsb02 9 years ago.
Failing build log of mc 4.8.17 on FreeBSD 11-current
patch-src_cons.handler.c​ (641 bytes) - added by woodsb02 9 years ago.
Patch to fix build of mc 4.8.17 on FreeBSD (replace min with MIN in src/cons.handler.c)

Change History

Changed 9 years ago by woodsb02

Failing build log of mc 4.8.17 on FreeBSD 11-current

Changed 9 years ago by woodsb02

Patch to fix build of mc 4.8.17 on FreeBSD (replace min with MIN in src/cons.handler.c)

comment:1 Changed 9 years ago by zaytsev

  • Status changed from new to accepted
  • Owner set to zaytsev
  • Milestone changed from Future Releases to 4.8.18

comment:2 Changed 9 years ago by zaytsev

  • Branch state changed from no branch to on review

Branch: 3643_cons_handler_min_macro
Initial changeset: 1afe2a091abc9b3e552942c42fc3af1b78a48944

comment:3 Changed 9 years ago by zaytsev

Hi Ben, thank you for the patch, and sorry for the FTBFS. Unfortunately, we don't have a FreeBSD builder, as Travis CI is Linux only, and so we've overlooked one instance of our proprietary min macro use in FreeBSD-only code during the latest refactoring round...

comment:4 Changed 9 years ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

comment:5 Changed 9 years ago by zaytsev

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [9cd1e165c5b9820c5cf59229cf28be679c4f8c2b]

comment:6 Changed 9 years ago by zaytsev

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.