Ticket #361 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

Hide editor private API

Reported by: andrew_b Owned by: andrew_b
Priority: major Milestone: 4.7.0-pre1
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

Currently, edit/edit.h contains a lot of declarations (functions defines, types, variables), but most of them are used internally in editor. Just several functions are used in MC core. So there is a reason to move all editor-private stuff to edit/edit-impl.h header and edit/edit.h header will be contain the public editor API only.

Change History

comment:1 Changed 10 years ago by andrew_b

  • Keywords review added
  • Owner set to andrew_b
  • Version changed from 4.6.2 to master
  • Status changed from new to accepted

Created 361_editor_public_api branch. Parent branch:master.
Initial changeset:5a7cc515bc1d28ddd05f5df224b516f079cc773f

comment:2 Changed 10 years ago by andrew_b

Added missed file.
Rebased to master.
changeset:e786322c15bbbf4b4c60501058f6ce749a0164c8

comment:3 Changed 10 years ago by angel_il

  • Keywords vote-angel_il added

comment:4 Changed 10 years ago by styx

  • Keywords vote-styx approved added; review removed

comment:5 Changed 10 years ago by andrew_b

  • Keywords commited-master added; vote-angel_il vote-styx approved removed
  • Status changed from accepted to testing
  • Resolution set to fixed

Merged to master.

Start changeset:fd09abaeb2ba0a839c3effbf9b7d72c6b208748d
End changeset:3337c39c5494a969427757125fd5e6dff45b03ec

git log --pretty=oneline fd09aba^..3337c39

comment:6 Changed 10 years ago by andrew_b

  • Status changed from testing to closed

comment:7 follow-up: ↓ 8 Changed 10 years ago by andrew_b

  • Status changed from closed to reopened
  • severity set to no branch
  • Resolution fixed deleted
  • Priority changed from minor to major
  • Milestone changed from 4.7 to 4.7.0-pre1
  • Keywords commited-master removed
  • Type changed from task to defect

Gabor Z. Papp <gzp at papp dot hu> reports that mc cannot be built with --without-edit option.

user.o: In function `expand_format':
/home/gzp/src/mc/src/user.c:190: undefined reference to `edit_get_file_name'
/home/gzp/src/mc/src/user.c:235: undefined reference to `edit_get_curs_col'
/home/gzp/src/mc/src/user.c:239: undefined reference to `edit_get_syntax_type'
user.o: In function `test_condition':
/home/gzp/src/mc/src/user.c:442: undefined reference to `edit_get_syntax_type'
collect2: ld returned 1 exit status

comment:8 in reply to: ↑ 7 Changed 10 years ago by andrew_b

  • Component changed from mcedit to mc-core
  • severity changed from no branch to on review

Created 361_without_edit branch. Parent branch: master.
changeset:264a87697fa5a5cfce7032509d73235f1949ee6a

comment:9 Changed 10 years ago by angel_il

  • Votes for changeset set to angel_il

comment:10 Changed 10 years ago by iNode

  • Votes for changeset changed from angel_il to angel_il iNode
  • severity changed from on review to approved

comment:11 Changed 10 years ago by andrew_b

  • Status changed from reopened to closed
  • Votes for changeset changed from angel_il iNode to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged
Note: See TracTickets for help on using tickets.