Ticket #3599 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

FISH: device file shows always major/minor 0:0

Reported by: ahauras Owned by: zaytsev
Priority: minor Milestone: 4.8.16
Component: mc-vfs Version: 4.8.14
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

steps to reproduce the problem:

  1. Open fish(ssh) connection
  2. navigate to /dev
  3. check that source minor/major of all special files is (0,0)
  4. copy file to local host (as root), all files copied as minor:major (0,0)

What is the expected output?
Showing and copying device files with correct (major:minor)
OR
If it is not possible, give error ("copying special files not supported") while copying such files.

What do you see instead?
Files copied as minor:major (0,0) and it makes such files totally useless (and possibly dangerous)

MC version:
GNU Midnight Commander 4.8.14
Built with GLib 2.44.1
Using the S-Lang library with terminfo database
With builtin Editor
With subshell support as default
With support for background operations
With mouse support on xterm
With internationalization support
With multiple codepages support
Virtual File Systems: cpiofs, tarfs, sfs, extfs, ext2undelfs, ftpfs, fish
Data types: char: 8; int: 32; long: 32; void *: 32; size_t: 32; off_t: 64;

# LC_MESSAGES=C mc -F
Root directory: /root

[System data]

Config directory: /etc/mc/
Data directory: /usr/share/mc/
File extension handlers: /usr/libexec/mc/ext.d/
VFS plugins and scripts: /usr/libexec/mc/

extfs.d: /usr/libexec/mc/extfs.d/
fish: /usr/libexec/mc/fish/

[User data]

Config directory: /root/.config/mc/
Data directory: /root/.local/share/mc/

skins: /root/.local/share/mc/skins/
extfs.d: /root/.local/share/mc/extfs.d/
fish: /root/.local/share/mc/fish/
mcedit macros: /root/.local/share/mc/mc.macros
mcedit external macros: /root/.local/share/mc/mcedit/macros.d/macro.*

Cache directory: /root/.cache/mc/

# mc --configure-options

'--prefix=/usr' '--build=i686-pc-linux-gnu' '--host=i686-pc-linux-gnu' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--datadir=/usr/share' '--sysconfdir=/etc' '--localstatedir=/var/lib' '--libdir=/usr/lib' '--disable-silent-rules' '--disable-dependency-tracking' '--enable-nls' '--enable-vfs' '--enable-vfs-undelfs' '--enable-charset' '--without-x' '--disable-vfs-smb' '--disable-vfs-sftp' '--disable-aspell' '--without-gpm-mouse' '--with-screen=slang' '--with-internal-edit' '--disable-mclib' '--disable-tests' '--with-homedir=XDG' 'build_alias=i686-pc-linux-gnu' 'host_alias=i686-pc-linux-gnu' 'CFLAGS=-O2 -m32 -march=pentium3 -mtune=haswell -pipe' 'LDFLAGS=-Wl,-O1 -Wl,--as-needed' 'PKG_CONFIG_PATH=/usr/lib/pkgconfig'

Attachments

mc-3599-fish-provide-majorminor-info.patch (1.5 KB) - added by and 4 years ago.

Change History

comment:1 Changed 4 years ago by and

Thanks for reporting, ahauras.

Currently mc fish helper provide no major/minor info for block/char devices.

attached patch will fix it.

Changed 4 years ago by and

comment:2 Changed 4 years ago by and

  • Milestone changed from Future Releases to 4.8.16

comment:3 Changed 4 years ago by ahauras

Just tested, works! Thank You!

comment:4 Changed 4 years ago by zaytsev

  • Status changed from new to accepted
  • Owner set to zaytsev

comment:5 Changed 4 years ago by zaytsev

  • Branch state changed from no branch to on review

Branch: 3599_fish_minor_major
Initial changeset: [ee6dd89deb5bbe28e60d5d7634d4c84b3cdd947e]

comment:6 Changed 4 years ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

comment:7 Changed 4 years ago by zaytsev

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

comment:8 Changed 4 years ago by zaytsev

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.