Ticket #3568 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

view basic information for JPEG files with image.sh without installed exif tool

Reported by: SubOptimal Owned by: zaytsev
Priority: trivial Milestone: 4.8.16
Component: mc-core Version: master
Keywords: image.sh jpeg Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

Pressing F3 on a JPEG file without EXIF information does not show the basic information provided by "identify".

Reason is that if "exif" tool is not installed, "identify" will also not be called for JPEG files.

which exif >/dev/null 2>&1 && \
{

identify "${MC_EXT_FILENAME}"; exif "${MC_EXT_FILENAME}" 2>/dev/null

}

GNU Midnight Commander 4.8.13
Built with GLib 2.42.1
Using the S-Lang library with terminfo database
With builtin Editor
With subshell support as default
With support for background operations
With mouse support on xterm and Linux console
With support for X11 events
With internationalization support
With multiple codepages support
Virtual File Systems: cpiofs, tarfs, sfs, extfs, ext2undelfs, ftpfs, sftpfs, fish
Data types: char: 8; int: 32; long: 64; void *: 64; size_t: 64; off_t: 64;

Attachments

0001-fix-image-view-for-JPEG.patch (891 bytes) - added by SubOptimal 4 years ago.
mc-3568-fix-image-view-info-for-JPEG.patch (807 bytes) - added by and 4 years ago.

Change History

Changed 4 years ago by SubOptimal

comment:1 Changed 4 years ago by and

nice catch
but I prefer which over type because busybox don't support type at least.

Changed 4 years ago by and

comment:2 Changed 4 years ago by and

  • Milestone changed from Future Releases to 4.8.16

comment:3 Changed 4 years ago by zaytsev

  • Status changed from new to accepted
  • Owner set to zaytsev

comment:4 Changed 4 years ago by zaytsev

  • Branch state changed from no branch to on review

Branch: 3568_image_view_jpeg
Initial changeset: 65421dcac7f5aee72b846c10606b94bba1d17d8d

comment:5 Changed 4 years ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

comment:6 Changed 4 years ago by zaytsev

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

comment:7 Changed 4 years ago by zaytsev

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.