search: Non-match not reported for parsed files from the beginning

[egmont]

Open a file in mcview's "Parsed" mode (you see "8Raw" at the bottom). E.g. F3 on a tarball (like mc-4.8.14.tar.xz, or whatever).

Press F7 and search for a string that doesn't occur in the file, such as "asdf".

Expected: A new error dialog informing you about the string not being found.

Actual: Nothing. The search dialog disappears and you're back in the file viewer.

Seems to occur only if you're in Parsed mode, and only if you start the search from the beginning of the file.

Broke somewhere between 4.8.12 and 4.8.13.

[egmont]

dc03e9e28d9c58df9c37e6911e54944fd5a5bdca is the first bad commit
commit dc03e9e28d9c58df9c37e6911e54944fd5a5bdca
Author: Andrew Borodin <aborodin@…>
Date: Thu Mar 14 16:21:41 2013 +0400

mcviewer: apply status message for search process.

Signed-off-by: Andrew Borodin <aborodin@…>

[egmont]

@andrew_b:

Could you please take a look at this? You're much more familiar with this part of the code than I am.

I've got plenty of things to do nowadays, I'm not planning to work on this bug.

search_start's off-by-one semantics (#3280) might be relevant, not sure.

[zaytsev]

I just wanted to post:

D'oh, sounds like a suicide to look into it without a bisection :-/

and I've a Trac editing conflict. Guess what? You've just bisected it! Well done :-)

[andrew_b]

Branch: 3534_mcview_not_found
Initial changeset:7233ed9a0949cee15d7f55fc37431fde7e11b89d

[egmont]

@andrew_b:

Sorry for not responding earlier. I haven't looked at the code, just applied the patch now and it seems to work. I'll keep on using it.

Note: the ticket number in the git branch name is incorrect.

[andrew_b]

Ticket #3576 has been marked as a duplicate of this ticket.

[andrew_b]

Branch was renamed: 3543_mcview_not_found.
Initial changeset:7233ed9a0949cee15d7f55fc37431fde7e11b89d

I'm still waiting for any vote.

[andrew_b]

Replying to andrew_b:

I'm still waiting for any vote.

"Tom!"
No answer.
"Tom!"
No answer.

Yet another week of silence.
O'key.

[andrew_b]

Merged to master: [72e20fce47b6cd123426ac246702d58604d8e300].

git log --pretty=oneline 1cf18ab..72e20fc