Ticket #3525 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

Search: Whole word only works in normal mode

Reported by: egmont Owned by: andrew_b
Priority: major Milestone: 4.8.15
Component: mc-search Version: master
Keywords: Cc: zaytsev
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

Originally reported in ticket #3449 comment 16:

The "Whole words" feature of search only works in Normal mode, not in any of the other modes (Regex, Hex, Wildcard).

The code piece that adds the guards for whole words resides in lib/search/normal.c and is only executed in Normal mode.

Attachments

mc-3525-whole-words.patch (1.8 KB) - added by egmont 4 years ago.
Fix

Change History

Changed 4 years ago by egmont

Fix

comment:1 Changed 4 years ago by egmont

Fix attached, goes on top of #3524's patch.

Should run "make indent" before submitting, a whole new nesting level is introduced but I didn't want to include that reformatting in the patch. Or go with an ifdef-maze of separating declaration of variables from the actual code... ugly.

comment:2 Changed 4 years ago by zaytsev

  • Cc zaytsev added

Thank you for making a proper report! Subscribing myself.

comment:3 Changed 4 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.15

comment:4 Changed 4 years ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

comment:5 Changed 4 years ago by andrew_b

  • Votes for changeset changed from andrew_b to committed-master
  • Branch state changed from approved to merged

Thanks! Applied.
Merged to master: [1f0dee6b520ede7780ecd1f5ddc55c29247e0c07].

comment:6 Changed 4 years ago by andrew_b

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:7 Changed 4 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.