Ticket #3496 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

Files of "unsorted" list shuffled

Reported by: Nicolas Rybkin Owned by: andrew_b
Priority: major Milestone: 4.8.15
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

I've found that qsort() may shuffle first and last files in some lists when sort_order is "unsorted". The solution is not to call qsort() for this sort_order.
*This is realy important issue* Sometimes user needs to know natural order of files in the list.

Attachments

dir.c (21.9 KB) - added by Nicolas Rybkin 4 years ago.
fixed dir.c
dir.c.diff (271 bytes) - added by Nicolas Rybkin 4 years ago.

Change History

Changed 4 years ago by Nicolas Rybkin

fixed dir.c

Changed 4 years ago by Nicolas Rybkin

comment:1 Changed 4 years ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.15

comment:2 Changed 4 years ago by mooffie

For reference, here's the mailing-list thread:

https://mail.gnome.org/archives/mc-devel/2015-June/msg00038.html

comment:3 Changed 4 years ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

comment:4 Changed 4 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

comment:5 Changed 4 years ago by andrew_b

  • Status changed from testing to closed

comment:6 Changed 4 years ago by zaytsev

Note: See TracTickets for help on using tickets.