Ticket #3493 (closed task: fixed)

Opened 4 years ago

Last modified 4 years ago

Switch "Local"/"User" buttons on menu selector

Reported by: mooffie Owned by: andrew_b
Priority: trivial Milestone: 4.8.15
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

The menu item "Command > Edit menu file" brings up the following dialog:

+------------- Menu edit --------------+
| Which menu file do you want to edit? |
|--------------------------------------|
| [ Local ] [ User ] |
+--------------------------------------+

The first button is "Local", and therefore has the focus. But since users are more likely to want to edit their central user menu, not the local menu, it's better to make the "User" button the first one.

Attachments

3493-Switch-Local-User-buttons-on-menu-selector.patch (1.6 KB) - added by mooffie 4 years ago.
3493-Menu-selector-make-User-not-Local-the-focused-button.patch (909 bytes) - added by mooffie 4 years ago.
3493-just-mcedit.patch (927 bytes) - added by mooffie 4 years ago.
3493-everything.patch (1.4 KB) - added by mooffie 4 years ago.

Change History

Changed 4 years ago by mooffie

comment:1 in reply to: ↑ description ; follow-up: ↓ 2 Changed 4 years ago by andrew_b

I think, the simplest way is move focus to "User" button without any other changes.

comment:2 in reply to: ↑ 1 Changed 4 years ago by mooffie

Replying to andrew_b:

I think, the simplest way is move focus to "User" button without any other changes.

Woa, I didn't know about query_set_sel(). I'll upload a "fixed" patch in a minute.

comment:3 Changed 4 years ago by mooffie

(Feel free to ignore this comment.)

IMHO, this dialog is somewhat problematic. I always hesitate on its question, although I'm certainly not an MC novice. It's not quite clear what "local" and "user" mean. Another issue is the use of buttons. Perhaps radios would be more natural there.

I tried to play with some alternatives, just to see if we can arrive at something better:

http://i.imgur.com/ZjiUaXb.png

(I created this in mc2 in a matter of minutes.)

But I don't think these alternatives are a substantial improvement, so let's put this issue to rest. Perhaps in the future we'll add a "Help" button for dialogs; this may alleviate the problem.

(Since I already mentioned mc2: it comes with a snippet that moves the focus to "User".)

comment:4 follow-up: ↓ 5 Changed 4 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.15

Branch: 3493_user_menu_focused_button
Initial changeset:24cd2bae8d3fd0c652ca29dce1e24055e6299bf3

What about the same change for mcedit menu selector?

Last edited 4 years ago by andrew_b (previous) (diff)

comment:5 in reply to: ↑ 4 Changed 4 years ago by mooffie

Replying to andrew_b:

What about the same change for mcedit menu selector?

Ooh, you're right. I didn't know we had this issue in yet another place.

What's the procedure? Should I post a patch that adds the fix, or should I post a patch that includes everything? I'll do both here, but let me know so I know what to do in the future.

"3493-just-mcedit.patch" is just the addition.
"3493-everything.patch" is everything.

Changed 4 years ago by mooffie

Changed 4 years ago by mooffie

comment:6 Changed 4 years ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

comment:7 Changed 4 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [6c949566cbd6a2e34045ffa55df124401a89524f].

git log --pretty=oneline bb5807e..6c94956

comment:8 Changed 4 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.