Ticket #3491 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

Case insensetive search is not available anymore in non-unicode locale

Reported by: andrew_b Owned by: andrew_b
Priority: major Milestone: 4.8.16
Component: mc-search Version: 4.8.14
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description (last modified by andrew_b) (diff)

This bug was introduced in [1a1496fc0dc13998803be9caf149ce3be8af9206].

How to reproduce.

  1. Switch to the any 8-bit locale (KOI8-R as example).
  2. Create text file with non-latin symbols in any charset (utf-8, cp1251, koi8-r, etc).

For example, cyrillic text:

ШШ
шш
шШ

where Ш is the upper-case letter (capital), ш is the lower-case one.

  1. Open this file in internal editor or viewer.
  2. Press F7 and enter Ш in the input line. Check the "Case sensitive" option off. Press Enter.

Result: only Ш is found, ш is not found at all.
Expected result: ш is as found as Ш.

Change History

comment:1 Changed 4 years ago by andrew_b

  • Component changed from mc-core to mc-search

comment:2 Changed 4 years ago by andrew_b

  • Description modified (diff)

comment:3 Changed 4 years ago by andrew_b

  • Description modified (diff)

comment:4 Changed 4 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.16

comment:5 follow-up: ↓ 6 Changed 4 years ago by zaytsev

Sorry, but why it was necessary to delete the test and inline this function instead of fixing the test?

comment:6 in reply to: ↑ 5 Changed 4 years ago by andrew_b

Replying to zaytsev:

Sorry, but why it was necessary to delete the test and inline this function instead of fixing the test?

With this function, we have two identical conditions: 1st in calling function, 2nd in called one. Merge of two branches simplifies code.

Last edited 4 years ago by andrew_b (previous) (diff)

comment:7 Changed 4 years ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

comment:8 Changed 4 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

comment:9 Changed 4 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.