Ticket #3479 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

Fix mc.pot comment tripping up Transifex and unportable inplace sed

Reported by: zaytsev Owned by: zaytsev
Priority: major Milestone: 4.8.15
Component: mc-core Version: master
Keywords: Cc: andrew_b
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

Transifex doesn't like when there is no space after # and complains about autogenerated /# "Plural-Forms ... string.

According to git blame, commenting of the plural forms string generated by gettext was added by Slava at some point. The solution is simply to add a space to the rule.

While we are at it, I suggest to replace unportable inplace sed invocation to remove location info with the usual "in/out/move" dance.

Change History

comment:1 Changed 7 years ago by zaytsev

  • Status changed from new to accepted
  • Owner set to zaytsev

comment:2 Changed 7 years ago by zaytsev

  • Status changed from accepted to testing
  • Votes for changeset set to committed-master
  • Resolution set to fixed
  • Branch state changed from no branch to merged

comment:3 Changed 7 years ago by zaytsev

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.