Ticket #347 (closed task: fixed)

Opened 10 years ago

Last modified 9 years ago

Replace src/profile.[ch] stuff to glib functions

Reported by: slavazanko Owned by: slavazanko
Priority: major Milestone: 4.7
Component: mc-core Version: master
Keywords: commited-master Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description (last modified by slavazanko) (diff)

Key-value file parser in glib library fully replace (and add additional features) some self-made src/profile.[ch] stuff

Change History

comment:1 Changed 10 years ago by slavazanko

  • Status changed from new to accepted
  • Owner set to slavazanko

branch 347_replace_profile_src, parent: master

changeset:298b992e827c9a25aae9c2101a8395682542eeb6

comment:2 Changed 10 years ago by slavazanko

  • Keywords review added

comment:3 Changed 10 years ago by andrew_b

  • Keywords vote-andrew_b added

Fine! My vote here.

comment:4 Changed 10 years ago by styx

  • Keywords vote-styx approved added; review removed

comment:5 Changed 10 years ago by slavazanko

  • Status changed from accepted to testing
  • Keywords commited-master added; vote-andrew_b vote-styx approved removed
  • Resolution set to fixed
  • Description modified (diff)

comment:6 Changed 10 years ago by styx

  • Status changed from testing to closed

comment:7 Changed 10 years ago by angel_il

  • Keywords rework added; commited-master removed
  • Status changed from closed to reopened
  • Resolution fixed deleted

need rework and revert
at now
key1=val1
key1=val2
key1=val3
work incorrect.

maybe need do
key1=val1, val2, val3
or
key1(1)=val1
key1(2)=val2
key1(3)=val3

comment:8 Changed 10 years ago by slyfox

Yes, it's clearly serious regression. Reverting 2 commits:

4648ad8bf9d72895a049280c52fb3f0e2bfa771c
483a1a05aa33b99ae4c0f11ac308c247044ddc10

(effectively reverts 212ab415085a3927c06ccc95508a308884c388a1 merge)

comment:9 Changed 10 years ago by slavazanko

  • Keywords review added; rework removed

reated branch 347_replace_self_ini_work (parent branch: master)

review, please

comment:10 Changed 10 years ago by slavazanko

  • Keywords rework added; review removed

need little rework... :)

comment:11 follow-up: ↓ 13 Changed 10 years ago by slavazanko

  • Keywords review added; rework removed

Panel states now read once from ini-file, then will save in separate ~/.mc/panels.ini file

Also, fixed ESC-sequenses in mc.lib file

Review, please.

comment:12 Changed 10 years ago by slavazanko

  • Description modified (diff)

comment:13 in reply to: ↑ 11 ; follow-up: ↓ 14 Changed 10 years ago by andrew_b

  • Version changed from 4.6.2 to master

Replying to slavazanko:

Panel states now read once from ini-file,

...but not applied.

then will save in separate ~/.mc/panels.ini file

Actually, ~/.mc/panels.ini doesn't contain current panel settings.

comment:14 in reply to: ↑ 13 Changed 10 years ago by andrew_b

  • Keywords vote-andrew_b added

Replying to andrew_b:

Replying to slavazanko:
...but not applied.
Actually, ~/.mc/panels.ini doesn't contain current panel settings.

Sorry. My mistake. Works correct. My vote.

comment:15 Changed 10 years ago by slavazanko

  • Blocking 380 added

comment:16 Changed 10 years ago by slavazanko

  • Blocking 386 added

comment:17 Changed 10 years ago by slavazanko

  • Blocking 367 added

comment:18 Changed 10 years ago by slyfox

  • Keywords vote-slyfox approved added; review removed

comment:19 Changed 10 years ago by slavazanko

  • Keywords commited-master added; vote-andrew_b vote-slyfox approved removed
  • Status changed from reopened to closed
  • Resolution set to fixed
  • Blocking 367, 380, 386 removed
Note: See TracTickets for help on using tickets.