[patch] cleanup -Wunreachable-code warnings

[and]

fix -Wunreachable-code warnings and add to mc cflags

input_complete.c:1170:9: warning: 'break' will never be executed [-Wunreachable-code-break]
ascii.c:291:12: error: 'return' will never be executed [-Wunreachable-code-return]
cons.saver.c:211:9: warning: 'break' will never be executed [-Wunreachable-code-break]

Signed-off-by: Andreas Mohr <and@…>

[zaytsev]

and, are you interested in triaging our Coverity report? Just thought you might find it funny since you're systematically checking the code for non-default warnings. If yes, then please register and apply for access to our project:

​https://scan.coverity.com/projects/1912

I've uploaded a build of master branch a couple of days ago, so the data is still fresh.

andrew_b, are you applying this in master or a cleanup branch? Do you think it would make sense for me to submit the cleanup branch to Coverity instead, if and is interested to avoid triaging what has already been fixed?

[andrew_b]

Replying to zaytsev:

andrew_b, are you applying this in master or a cleanup branch?

In 3420_cleanup branch.

Do you think it would make sense for me to submit the cleanup branch to Coverity instead,

Yes, I do.

[andrew_b]

Thanks!
Applied as [f023a83502ceef05ee937725b0ac14bbdf082775].

[and]

Hi zaytev,
can you approve my request at
​https://scan.coverity.com/projects/1912

[zaytsev]

Hi Andreas,

I hope I did it right - if I have to upload something for you, let me know.

Yury

[and]

Thanks, now I see more.

Last run from 2014 is too old.

Can you/we(?) bump against current 4103_cleanup branch?
Looks like only admin(?) can "Submit build" at coverity Project Settings?

Or if I know the specific project coverity-token (from .travis.yml) I can trigger by myself,
by a simple curl request.

[zaytsev]

Hi Andreas,

I've just sent you an email.

All the best,
Yury

[and]

Thanks,
uploaded 4.8.25-99-gf9cce0d3a,
let see when Coverity dashboard is updated

[zaytsev]

Last Build Status: Failed. Your build has failed due to the following reason. Please fix the error and upload the build again.

[and]

mhh, are there error details?

[and]

fixed, tar content path was not relative.