Ticket #3467 (closed defect: fixed)

Opened 7 years ago

Last modified 20 months ago

[patch] cleanup -Wunreachable-code warnings

Reported by: and Owned by:
Priority: minor Milestone: 4.8.15
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset:

Description

fix -Wunreachable-code warnings and add to mc cflags

input_complete.c:1170:9: warning: 'break' will never be executed [-Wunreachable-code-break]
ascii.c:291:12: error: 'return' will never be executed [-Wunreachable-code-return]
cons.saver.c:211:9: warning: 'break' will never be executed [-Wunreachable-code-break]

Signed-off-by: Andreas Mohr <and@…>

Attachments

mc-3467-cleanup-unreachable_code-warning.patch (2.2 KB) - added by and 7 years ago.

Change History

Changed 7 years ago by and

comment:1 Changed 7 years ago by andrew_b

  • Blocked By 3420 added

comment:2 follow-up: ↓ 3 Changed 7 years ago by zaytsev

and, are you interested in triaging our Coverity report? Just thought you might find it funny since you're systematically checking the code for non-default warnings. If yes, then please register and apply for access to our project:

https://scan.coverity.com/projects/1912

I've uploaded a build of master branch a couple of days ago, so the data is still fresh.

andrew_b, are you applying this in master or a cleanup branch? Do you think it would make sense for me to submit the cleanup branch to Coverity instead, if and is interested to avoid triaging what has already been fixed?

comment:3 in reply to: ↑ 2 Changed 7 years ago by andrew_b

Replying to zaytsev:

andrew_b, are you applying this in master or a cleanup branch?

In 3420_cleanup branch.

Do you think it would make sense for me to submit the cleanup branch to Coverity instead,

Yes, I do.

comment:4 Changed 7 years ago by andrew_b

  • Status changed from new to closed
  • Resolution set to fixed
  • Branch state changed from no branch to merged
  • Milestone changed from Future Releases to 4.8.15

comment:5 Changed 7 years ago by andrew_b

  • Blocked By 3420 removed

comment:6 Changed 20 months ago by and

Hi zaytev,
can you approve my request at
https://scan.coverity.com/projects/1912

comment:7 Changed 20 months ago by zaytsev

Hi Andreas,

I hope I did it right - if I have to upload something for you, let me know.

Yury

comment:8 Changed 20 months ago by and

Thanks, now I see more.

Last run from 2014 is too old.

Can you/we(?) bump against current 4103_cleanup branch?
Looks like only admin(?) can "Submit build" at coverity Project Settings?

Or if I know the specific project coverity-token (from .travis.yml) I can trigger by myself,
by a simple curl request.

comment:9 Changed 20 months ago by zaytsev

Hi Andreas,

I've just sent you an email.

All the best,
Yury

comment:10 Changed 20 months ago by and

Thanks,
uploaded 4.8.25-99-gf9cce0d3a,
let see when Coverity dashboard is updated

comment:11 Changed 20 months ago by zaytsev

Last Build Status: Failed. Your build has failed due to the following reason. Please fix the error and upload the build again.

comment:12 Changed 20 months ago by and

mhh, are there error details?

comment:13 Changed 20 months ago by and

fixed, tar content path was not relative.

Note: See TracTickets for help on using tickets.