Ticket #3460 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

[patch] fix memleak at filemanager/panel.c:do_enter_on_file_entry()

Reported by: and Owned by:
Priority: major Milestone: 4.8.15
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset:

Description

fix memleak at filemanager/panel.c:do_enter_on_file_entry()

found by LeakSanitizer?

Direct leak of 24 byte(s) in 1 object(s) allocated from:

#0 0x4d5edb in calloc (/tmp/portage/app-misc/mc-9999/work/mc-9999/src/mc+0x4d5edb)
#1 0x7f9bc7bfe85c in g_malloc0 (/usr/lib64/libglib-2.0.so.0+0x6785c)
#2 0x5e5a68 in vfs_path_new /tmp/portage/app-misc/mc-9999/work/mc-9999/lib/vfs/path.c:781:13
#3 0x5e4799 in vfs_path_from_str_uri_parser /tmp/portage/app-misc/mc-9999/work/mc-9999/lib/vfs/path.c:444:13
#4 0x5e383b in vfs_path_from_str_flags /tmp/portage/app-misc/mc-9999/work/mc-9999/lib/vfs/path.c:746:17
#5 0x5e949c in vfs_path_build_filename /tmp/portage/app-misc/mc-9999/work/mc-9999/lib/vfs/path.c:1245:13
#6 0x5e963b in vfs_path_append_new /tmp/portage/app-misc/mc-9999/work/mc-9999/lib/vfs/path.c:1277:17
#7 0x5c7d4b in do_enter_on_file_entry /tmp/portage/app-misc/mc-9999/work/mc-9999/src/filemanager/panel.c:2745:23
#8 0x5cda2a in panel_execute_cmd /tmp/portage/app-misc/mc-9999/work/mc-9999/src/filemanager/panel.c:3398:9
#9 0x52fc94 in dlg_key_event /tmp/portage/app-misc/mc-9999/work/mc-9999/lib/widget/dialog.c:515:19
#10 0x530546 in frontend_dlg_run /tmp/portage/app-misc/mc-9999/work/mc-9999/lib/widget/dialog.c:570:9
#11 0x530165 in dlg_run /tmp/portage/app-misc/mc-9999/work/mc-9999/lib/widget/dialog.c:1267:5
#12 0x5a1f4a in do_nc /tmp/portage/app-misc/mc-9999/work/mc-9999/src/filemanager/midnight.c:1762:9
#13 0x4fa3e8 in main /tmp/portage/app-misc/mc-9999/work/mc-9999/src/main.c:418:21
#14 0x7f9bc6ccf133 in libc_start_main (/lib64/libc.so.6+0x20133)
#15 0x44ed96 in _start (/tmp/portage/app-misc/mc-9999/work/mc-9999/src/mc+0x44ed96)

Signed-off-by: Andreas Mohr <and@…>

Attachments

mc-3460-fix-memleak-full_name_vpath.patch (2.0 KB) - added by and 7 years ago.

Change History

Changed 7 years ago by and

comment:1 Changed 7 years ago by andrew_b

  • Blocked By 3420 added

comment:2 Changed 7 years ago by andrew_b

  • Status changed from new to closed
  • Resolution set to fixed
  • Branch state changed from no branch to merged
  • Milestone changed from Future Releases to 4.8.15

Thanks!
Applied with some optimization as [f379339002042f76ea5c21dd117620bd69792842].

comment:3 Changed 7 years ago by andrew_b

  • Blocked By 3420 removed
Note: See TracTickets for help on using tickets.