Ticket #344 (closed defect: fixed)

Opened 10 years ago

Last modified 9 years ago

git master: editor: tab key works incorrectly when block is marked(F3)

Reported by: slyfox Owned by: angel_il
Priority: major Milestone: 4.7
Component: mc-core Version:
Keywords: commited-master Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description (last modified by slyfox) (diff)

Let's create small file:

foo
bar
quux
baz

Let's mark 'oo' substring and thentry to insert TAB in between of 'uu'.
We expect something like this:

f<F3>oo</F3>
bar
qu<--------><cursor-pos/>ux
baz

But we get:

<-------->f<F3>oo</F3>
bar
qu<cursor-pos/>ux
baz

Tab is placed at marked line, not at cursor-pos.

Change History

comment:1 Changed 10 years ago by slyfox

  • Description modified (diff)

comment:2 Changed 10 years ago by angel_il

its no bug, its - feature.
Tab - shift selected block to right.
Complete (alt-tab) - shift selected block to left.

comment:3 follow-up: ↓ 4 Changed 10 years ago by slyfox

Ok, then the bug is ill chosen hotkeys :]

  • Alt-Tab is usually used to switch windows in windows managers
  • Tab is usually used to place regular tab, it's very unintuitive behaviour.

What hotkeys do other editors use for that? For example visual studio?

comment:4 in reply to: ↑ 3 Changed 10 years ago by angel_il

Replying to slyfox:

  • Alt-Tab is usually used to switch windows in windows managers

you can use esc-tab or learn Shift-Tab as Alt-Tab.

comment:5 Changed 10 years ago by angel_il

i think best for you is option - tab_shift_block = 0

comment:6 Changed 10 years ago by slavazanko

If this will be option, you should have thought about the menu or hotkey to switch to this behavior

comment:7 Changed 10 years ago by slyfox

  • Keywords review vote-slyfox added

Ok, at least old behaviour is returned. my vote.

comment:8 Changed 10 years ago by slavazanko

  • Keywords vote-slavazanko approved added; review removed

Good patch. Tabbing of selection may sense only with non-persistent selections.

With persistent selection this looks as bug :)

My vote here.

comment:10 Changed 10 years ago by angel_il

  • Status changed from new to assigned
  • Keywords commited-master added; vote-slyfox vote-slavazanko approved removed
  • Owner set to angel_il

comment:11 Changed 10 years ago by angel_il

  • Status changed from assigned to testing
  • Resolution set to fixed

comment:12 Changed 10 years ago by angel_il

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.