Ticket #3416 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

viewer case insensitive search doesn't find accents

Reported by: egmont Owned by: slavazanko
Priority: critical Milestone: 4.8.14
Component: mc-search Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

Regression since 4.8.13. Fully UTF-8 environment.

Open the attached file in mcview. Search (F7) for Szerémi in case insensitive mode. No match found, although it's definitely contained in the file multiple times.

Attachments

stops.txt (1.8 KB) - added by egmont 4 years ago.
mc-3416-case-insensitive-search.patch (4.2 KB) - added by egmont 4 years ago.
Fix

Change History

Changed 4 years ago by egmont

comment:1 Changed 4 years ago by egmont

  • Milestone changed from Future Releases to 4.8.14

git bisect says:

commit 933fd255d07f8bdb9ffe020bda259102890e971a

Ticket #2743: File selection by patterns uses bytes instead of (unicode) characters.

Using the "?" pattern in the file selection dialog brought up with '+',
mc uses the file name length in bytes instead of characters.

comment:2 Changed 4 years ago by egmont

Note that the same bug is present in:

  • viewer's search
  • editor's search
  • find file
  • select files
  • (...?)

comment:3 Changed 4 years ago by egmont

  • Component changed from mcview to mc-core

comment:4 Changed 4 years ago by slavazanko

  • Status changed from new to accepted
  • Owner set to slavazanko

comment:5 Changed 4 years ago by egmont

Patch attached, please test+review it.

(Note: I haven't run the unittests, I don't know how to do it and too lazy to look it up right now :) Please double check that, too.)

comment:6 Changed 4 years ago by egmont

I've updated the unittest bits to actually add unittests for case insensitive search. I still haven't compiled it, it might be broken, but it should be easy to fix :)

Changed 4 years ago by egmont

Fix

comment:7 Changed 4 years ago by slavazanko

  • Votes for changeset set to slavazanko
  • Branch state changed from no branch to approved

comment:8 Changed 4 years ago by slavazanko

  • Status changed from accepted to testing
  • Votes for changeset changed from slavazanko to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master:

git log --pretty=oneline 9204038...1a1496f

comment:9 Changed 4 years ago by slavazanko

  • Status changed from testing to closed
  • Component changed from mc-core to mc-search
Note: See TracTickets for help on using tickets.