bashism in /bin/sh script

[onlyjob]

As reported in ​https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=772306

Bashism were found in the src/vfs/extfs/helpers/gitfs+ file:

26:    echo -e "$2" > "$4"

Therefore correct functioning of this script is not guaranteed under "/bin/sh".
"echo -e" should be replaced with "printf", see more:

​https://wiki.ubuntu.com/DashAsBinSh#echo

[onlyjob]

Something like this can fix it:

--- a/src/vfs/extfs/helpers/gitfs+
+++ b/src/vfs/extfs/helpers/gitfs+
@@ -22,9 +22,9 @@
 }
 
 gitfs_copyout()
 {
-    echo -e "$2" > "$4"
+    printf "$2\n" > "$4"
     b=`echo "$prefix"| wc -c`
     b=`expr "$b" + 1`
     # remove prefix from file name
     echo "`dirname "$3"`/`basename "$3" | tail -c+"$b"`" >> "$4"

Alternatively "/bin/echo -e" can be used instead of "echo -e".

[ossi]

you just committed "printf usage FAILs 101".

printf "%s\n" "$2" > "$4"

[egmont]

Replying to ossi:

you just committed "printf usage FAILs 101".

So did the original echo command :) in fact, every echo command whose first parameter is untrusted. Both bash's and coreutils's echo recognize certain flags but not "--".

printf %s is indeed the right way to go.

[zaytsev]

Committed as fb9caaa6718c8553aeaf46a77ca5be7ac164a077 in 3547_cleanup.

[andrew_b]

Applied as [391821e4ab37ac4f16b93525d8837c9feb088f2f].