Ticket #337 (closed defect: fixed)
wrong $PS1 parser in command line input
| Reported by: | styx | Owned by: | slyfox |
|---|---|---|---|
| Priority: | trivial | Milestone: | |
| Component: | mc-core | Version: | 4.6.2 |
| Keywords: | commited-mc-4.6 commited-master | Cc: | |
| Blocked By: | Blocking: | ||
| Branch state: | Votes for changeset: |
Description (last modified by slyfox) (diff)
https://bugs.launchpad.net/ubuntu/+source/mc/+bug/330633
patch provided by Sergey Nizovtsev.
based on: mc-4.6
branch: 337_ps1_fix
changeset: 9041e6c81f4b2ae15e7bc3f733016ec9250ea5aa
Attachments
Change History
comment:3 Changed 16 years ago by slavazanko
- Keywords vote-slavazanko approved added
Looks good. My vote here.
comment:4 Changed 16 years ago by slavazanko
- Keywords rework added; vote-styx vote-slavazanko approved removed
Sorry, vote removed.
http://www.patoche.org/LTT/shell/00000076.html
http://www.faqs.org/docs/Linux-mini/Xterm-Title.html
http://www.xfree86.org/current/ctlseqs.html
Need to fix all cases, IMHO
comment:5 Changed 16 years ago by slyfox
Patch looks wrong: it does not seem to handle correctly such pathological case:
PS1=esc(OSC)...esc(ST) ${GOOD_DATA1} esc(OSC)...esc(BEL) ${GOOD_DATA2}
As I understand it will drop all leaving ${GOOD_DATA2}
comment:7 Changed 16 years ago by slyfox
- Keywords review added; rework removed
- Milestone changed from 4.7 to 4.6.2.1
Applied in slightly reworked form. Please review.
comment:8 Changed 16 years ago by slavazanko
- Keywords vote-slavazanko added
looks good. Prompt show normal.
Vote here.
comment:9 Changed 16 years ago by styx
- Keywords vote-styx approved added; review removed
- Owner changed from styx to slyfox
- Status changed from accepted to assigned
comment:10 Changed 16 years ago by styx
- Keywords commited-mc-4.6 commited-master added; vote-slavazanko vote-styx approved removed
- Status changed from assigned to testing
- Resolution set to fixed
Note: See
TracTickets for help on using
tickets.
