Ticket #336 (closed defect: fixed)

Opened 10 years ago

Last modified 9 years ago

chgrp on the fish filesystem

Reported by: snizovtsev Owned by: slyfox
Priority: minor Milestone:
Component: mc-core Version: 4.6.2
Keywords: commited-master commited-mc-4.6 Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description

mc-4.6.2 have updated fish code that supports special characters in file names, but chgrp command haven't been updated.

--- fish.c.orig 2009-05-02 12:19:35.000000000 +0400
+++ fish.c 2009-05-02 12:20:07.000000000 +0400
@@ -980,7 +980,7 @@

/* FIXME: what should we report if chgrp succeeds but chown fails? */
g_snprintf (buf, sizeof(buf),

"#CHGRP /%s \"/%s\"\n"

  • "chgrp %s \"/%s\" 2>/dev/null\n"

+ "chgrp %s /%s 2>/dev/null\n"

"echo '### 000'\n",
sgroup, rpath.s,
sgroup, rpath.s);

Change History

comment:1 Changed 10 years ago by slyfox

  • Status changed from new to accepted
  • Owner set to slyfox

Fix is perfectly correct.
Looks like I've forgot to convert this one.

Thanks!

comment:2 Changed 10 years ago by slyfox

  • Keywords review vote-slyfox added

branch:336_fish_chgrp_escape
commit:027168ce3d20a83c887af2fcec255a4489f7c3c8

comment:3 Changed 10 years ago by slavazanko

  • Keywords vote-slavazanko added

Yep, fix looks good.

My vote here

comment:4 Changed 10 years ago by slavazanko

  • Keywords approved added; review removed

comment:5 Changed 10 years ago by slyfox

  • Status changed from accepted to testing
  • Keywords commited-master commited-mc-4.6 added; approved removed
  • Resolution set to fixed

Tested on master branch for directory ' "'
Fix heals chgrp failure.

comment:6 Changed 10 years ago by styx

  • Status changed from testing to closed
  • Keywords vote-slyfox vote-slavazanko removed

comment:7 Changed 9 years ago by anonymous

  • Milestone 4.6.2.1 deleted

Milestone 4.6.2.1 deleted

Note: See TracTickets for help on using tickets.