Ticket #3285 (closed defect: fixed)
mcedit: status line no longer shows full path to file
| Reported by: | onlyjob | Owned by: | andrew_b |
|---|---|---|---|
| Priority: | minor | Milestone: | 4.8.14 |
| Component: | mcedit | Version: | 4.8.13 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Branch state: | merged | Votes for changeset: | committed-master |
Description
As reported in Debian
mcedit used to print the full path of the current file in the status bar.
In new version of MC (4.8.13), this is unfortunately no longer the case.
(mcview still shows the full path).
I agree with reporter that it is more convenient to see full path in mcedit and that it is nice when such behaviour is in line with mcview. Please revert.
The following (untested) patch was proposed:
--- editdraw.c.orig 2014-09-02 12:23:58.000000000 +0300
+++ editdraw.c 2014-10-08 23:05:18.000000000 +0300
@@ -210,7 +210,7 @@
status_len = (int) str_term_width1 (status);
if (edit->filename_vpath != NULL)
- fname = x_basename (vfs_path_get_last_path_str (edit->filename_vpath));
+ fname = vfs_path_get_last_path_str (edit->filename_vpath);
fname_len = str_term_width1 (fname);
if (fname_len < preferred_fname_len)
@@ -264,7 +264,7 @@
if (edit->filename_vpath != NULL)
{
- fname = x_basename (vfs_path_as_str (edit->filename_vpath));
+ fname = vfs_path_as_str (edit->filename_vpath);
}
#ifdef ENABLE_NLS
else
Change History
comment:1 Changed 10 years ago by andrew_b
- Status changed from new to accepted
- Owner set to andrew_b
- Milestone changed from Future Releases to 4.8.14
comment:2 Changed 10 years ago by andrew_b
- Branch state changed from no branch to on review
Branch: 3285_mcedit_full_path.
changeset:00d9200352fd2ff0c9be4a669544a93efc031004
comment:3 Changed 10 years ago by slavazanko
- Votes for changeset set to slavazanko
- Branch state changed from on review to approved
comment:4 Changed 10 years ago by andrew_b
- Status changed from accepted to testing
- Votes for changeset changed from slavazanko to committed-master
- Resolution set to fixed
- Branch state changed from approved to merged
Merged to master: [be38f707040a223d29c7700c1a4957d6c9658d2e].
comment:6 follow-up: ↓ 7 Changed 9 years ago by onlyjob
- Status changed from closed to reopened
- Version changed from 4.8.13 to 4.8.15
- Resolution fixed deleted
- Milestone changed from 4.8.14 to Future Releases
Although this regression was fixed in 4.8.14 it returned with 4.8.15. Please fix it (again). Cheers.
comment:7 in reply to: ↑ 6 Changed 9 years ago by andrew_b
- Status changed from reopened to closed
- Version changed from 4.8.15 to 4.8.13
- Resolution set to fixed
- Milestone changed from Future Releases to 4.8.14
comment:8 Changed 9 years ago by onlyjob
I see, thanks. Perhaps defaults are badly chosen as mcview shows full path while mcedit is not. It would be better to preserve classic, consistent presentation instead of flipping it back and forth over last 3 releases. Also, I'd prefer accessing this configuration option from menu.
