Info panel can't obtain file system statistics

[mcermak]

On Solaris, when an info-panel is displayed, the file system information is not shown. No statistics is shown at all, as if the application can't perform statvfs() call.

# mc -V
GNU Midnight Commander 4.8.13
Built with GLib 2.28.6
Using the S-Lang library with terminfo database
With builtin Editor
With subshell support as default
With support for background operations
With mouse support on xterm
With support for X11 events
With internationalization support
With multiple codepages support
Virtual File Systems: cpiofs, tarfs, sfs, extfs, ftpfs, fish
Data types: char: 8; int: 32; long: 64; void *: 64; size_t: 64; off_t: 64;

This is due to uninitialized variable lockfd in filemanager/mountlist.c read_file_system_list() function (line 1002). lockfd is intialized in conditionally compiled code (line 1012) but used unconditionally (line 1059). This causes an error and the file system list read from /etc/mnttab is thrown away.

[mcermak]

Patch for 4.8.13

[andrew_b]

Is the following trivial patch enough?

--- a/src/filemanager/mountlist.c
+++ b/src/filemanager/mountlist.c
@@ -999,7 +999,7 @@ read_file_system_list (int need_fs_type)
         char *table = MNTTAB;
         FILE *fp;
         int ret;
-        int lockfd;
+        int lockfd = -1;
 
 #if defined F_RDLCK && defined F_SETLKW
         /* MNTTAB_LOCK is a macro name of our own invention; it's not present in

[mcermak]

Yes, that'll do. But the variable lockfd is useless when F_RDLCK or F_SETLKW is not defined.

[andrew_b]

Actually, most part of mc's mountlist is the mix of gnulib's mountlist and fsusage modules.

Replying to mcermak:

Yes, that'll do. But the variable lockfd is useless when F_RDLCK or F_SETLKW is not defined.

I try keep as much as possible the code taken from gnulib because I sync the mc code with gnulib one.
If you want you can send your patch to gnulib mailing list.

[andrew_b]

Fixed as part of #3265: [7f8135d071c0801d8861e240e13555f2fab6d24a].