Ticket #3263 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

[patch] mcview hex: Incorrect highlight when search string not found

Reported by: egmont Owned by: andrew_b
Priority: minor Milestone: 4.8.14
Component: mcview Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

echo abcdefghijklmnopqrstuvwxyz > abc
mcview abc (at 80 columns)

Switch to hex mode.

Search for klm. The match is highlighted properly.

With the left arrow, walk back to let's say "e" (65).

Search for asdf. It's not found, yet efghijklm is highlighted as found text.

Attachments

mc-4.8.13-restore_prev_selection_if_search_failed.patch (3.6 KB) - added by and 3 years ago.
restore prev string selection if search failed

Change History

Changed 3 years ago by and

restore prev string selection if search failed

comment:1 Changed 3 years ago by and

  • Summary changed from mcview hex: Incorrect highlight when search string not found to [patch] mcview hex: Incorrect highlight when search string not found

comment:2 Changed 3 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Votes for changeset set to andrew_b
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.14

Thanks! Applied.

Branch: 3263_hexview_highlight_found
changeset:15cf75d63ef47900dbdeff0b82320f848e38855e

comment:3 Changed 3 years ago by andrew_b

  • Branch state changed from on review to approved

comment:4 Changed 3 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

comment:5 Changed 3 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.