Ticket #3258 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

Incorrect percentage in mcview hex mode

Reported by: egmont Owned by:
Priority: minor Milestone: 4.8.13
Component: mcview Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: no branch Votes for changeset: committed-master

Description

mcview, hex mode

The percent in the upper right corner normally corresponds to the cursor. Except when the bottom of the file is displayed, then it's 100%.

If the file is taller than the window, you can walk downwards to its end and the percent is always correct. Then walk back a screenful and it stays at 100%, and suddenly jumps back by a lot when the file starts scrolling.

If the file is shorter than the window, it's always at 100%.

mcview_calc_percent() is supposed to calculate the percentage at offset p, yet it executes a special branch when "dpy_end == filesize".

Attachments

mc-3258-mcview-hex-percent.patch​ (613 bytes) - added by egmont 10 years ago.
Fix

Change History

Changed 10 years ago by egmont

Fix

comment:1 Changed 10 years ago by andrew_b

  • Blocked By 3189 added
  • Milestone changed from Future Releases to 4.8.13

comment:2 Changed 10 years ago by andrew_b

  • Status changed from new to closed
  • Votes for changeset set to committed-master
  • Resolution set to fixed

Applied as [584673c2602b098f8220183b888f28baa74f38ed].

comment:3 Changed 10 years ago by andrew_b

  • Blocked By 3189 removed
Note: See TracTickets for help on using tickets.