Ticket #3241 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

Colon not recognized inside escape seq in prompt

Reported by: egmont Owned by: andrew_b
Priority: minor Milestone: 4.8.13
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

export PS1=$'\[\e[38:5:214m\]orange$\[\e[0m\]'
mc

Expected: "orange$" prompt shows up in black under the panels.
Actual: some additional garbage

The 256-color and true-color escape sequences should allow either ';' or ':' inside as separator, actually, ':' is the more correct according to ECMA-48. Some terminal emulators (e.g. xterm, gnome-terminal) support this.

For details, see https://bugzilla.gnome.org/show_bug.cgi?id=685759 (the opening bugreport only).

Attachments

mc-3241-ansi-escape-sequence-colon.patch (496 bytes) - added by egmont 5 years ago.
fix

Change History

Changed 5 years ago by egmont

fix

comment:1 Changed 5 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.13

comment:2 Changed 5 years ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

comment:3 Changed 5 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

I also add some comment to the original patch.

Merged to master: [a3d75ae300c9a3150125324ae64db0b19506dadf].

comment:4 Changed 5 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.