Ticket #3235 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

copy files dosn't work as expected, when copying to a directory with the special symbol in its name

Reported by: mc_user Owned by: slavazanko
Priority: major Milestone: 4.8.14
Component: mc-core Version: master
Keywords: Cc: devel.openSUSE.org@…
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

When copying to directory with a name containing special symbol "*" the copy command didn't do it in a right way.

Steps to reproduce:

  1. cd to some directory;
  2. create directory named *TEST*;
  3. create directory named TMP and add some files to it and create file named COPY near TMP directory;

example of testing file tree:

/tmp/new44/*TEST* (dir)
/tmp/new44/TMP (dir)
/tmp/new44/TMP/test.log (file)
/tmp/new44/COPY (file)

  1. cd in one panel to *TEST* directory and try to copy TMP directory _and_ COPY file together to it;
  2. look at copied files in *TEST* directory

Actual result:

  • during copy operation you will get denied for COPY file;
  • after copying you will see that *TEST* contains only content of TMP, but not TMP or COPY file itself

Expected result:

  • midnight commander needs to handle this situation in right way, so you can copy any files and dirs to directories with "*" in it's names without issues (expected *TEST*/TMP and *TEST*/TMP/*, and *TEST*/COPY)

Attachments

escaped_star_isnt_wildcard.patch (644 bytes) - added by boris 3 years ago.

Change History

Changed 3 years ago by boris

comment:1 Changed 3 years ago by boris

I've patched my mc with the attached patch and the bug is gone.

comment:2 Changed 3 years ago by slavazanko

  • Owner set to slavazanko
  • Status changed from new to accepted

comment:3 Changed 3 years ago by slavazanko

  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.14

Created branch 3235_copy_with_special_symbols

initial changeset:1ae3a5279dc5405a30e518d78e8406b2a64faf1d

Review please.

comment:4 Changed 3 years ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

comment:5 Changed 3 years ago by slavazanko

  • Votes for changeset changed from andrew_b to committed-master
  • Branch state changed from approved to merged

Merged to master:

git log --pretty=oneline 482e96e...4d2cefa

comment:6 Changed 3 years ago by slavazanko

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:7 Changed 3 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.