Ticket #3230 (closed enhancement: fixed)

Opened 5 years ago

Last modified 5 years ago

PHP.syntax improvement

Reported by: ylavoie Owned by: slavazanko
Priority: trivial Milestone: 4.8.13
Component: mcedit Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

Current php.syntax (Utopic 3:4.8.12-1) gets confused with embedded HTML or DOCTYPE statements with strings.
Here's a suggested patch to fix it.

Attachments

php.syntax.patch (1014 bytes) - added by ylavoie 5 years ago.
Proposed patch

Change History

Changed 5 years ago by ylavoie

Proposed patch

comment:1 Changed 5 years ago by andrew_b

  • Component changed from mc-core to mcedit

comment:2 Changed 5 years ago by slavazanko

  • Status changed from new to accepted
  • Owner set to slavazanko

comment:3 Changed 5 years ago by slavazanko

  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.13

Created branch 3230_php_syntax (initial changeset:3690f6422ff03abce1c77e7a49d1f43796990713)
Please review.

comment:4 Changed 5 years ago by slavazanko

Branch was recreated. New initial changeset:e676918ea48fc2839fd00914b9ba86cc67797bd0

Please review.

comment:5 Changed 5 years ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

comment:6 Changed 5 years ago by slavazanko

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

comment:7 Changed 5 years ago by slavazanko

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.