Ticket #3221 (reopened defect)

Opened 5 years ago

Last modified 4 years ago

In "Directory Hotlist" the keyboard right button has stopped working for the final destination

Reported by: birdie Owned by:
Priority: major Milestone: Future Releases
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: no branch Votes for changeset:

Description

In earlier MC releases you could change to a final destination directory of your personal Directory Hotlist using the right button.

In MC 4.8.12 it's only possible via the Return (Enter) key.

Please, bring back the old functionality. Using the right key is a lot more convenient and fast.

Attachments

keyboard.png (2.5 KB) - added by birdie 5 years ago.
The Right Key (along with left up and down)

Change History

Changed 5 years ago by birdie

The Right Key (along with left up and down)

comment:1 Changed 5 years ago by andrew_b

  • Status changed from new to closed
  • Resolution set to wontfix
  • Milestone 4.8.13 deleted

See #3045.

comment:2 follow-up: ↓ 3 Changed 5 years ago by birdie

  • Status changed from closed to reopened
  • Resolution wontfix deleted

These two bugs have no relationship whatsoever.

The bug you're referring to is about VFS.

This bug is about the keyboard behavior in "Directory Hotlist".

What the hell?

comment:3 in reply to: ↑ 2 Changed 5 years ago by andrew_b

  • Status changed from reopened to closed
  • Resolution set to wontfix

Replying to birdie:

This bug is about the keyboard behavior in "Directory Hotlist".

What the hell?

Open your eyes: [0eb1f6fcae0710b25f9a11181238cd061a25121c].

comment:4 Changed 5 years ago by birdie

  • Status changed from closed to reopened
  • Resolution wontfix deleted

Can you please make this thing configurable? Or at least tell us how can I patch the sources to bring back the old behaviour?

Your commit explains almost everything aside from the fact that I don't mind that "Directory Hotlist" gets closed on final "Right".

Besides, from the commit message:

"Now 'Right' key is used only for 2) case and ignored in 1) and 2) cases."

Firstly, I don't get it as you made a mistake in the wording.

Secondly, why is closing a dialog using "Right" being inconsistent? Who decided that?

Thirdly, when I browse filesystem/VFS, I've never used the Right key. I "Enter" the directories I'm interested in. This is entirely different for "Directory Hotlist".

Fourthly, why do these two disconnected features share the same keyboard shortcuts? It makes zero sense.

Please, leave "Directory Hotlist" alone and make the Right key _just_ for this dialog a key which proceeds to the final destination. Don't make our lives harder.

Thank you.

comment:5 Changed 5 years ago by birdie

Besides, you never know when to hit "Enter". Are you on a last level of your Directory Tree or not? That's bloody confusing.

My muscle memory memory hates you. If you have several items reachable by a different number of "Right" keys, one should also memorize when to hit Enter and when to hit Right.

Is it

right -> enter?

or

right-> right -> enter?

or

right -> right-> right -> enter?

Damn, damn, damn!

If you are hell-bent on not having the "Right" key to work as _normally_ expected, totally _remove_ this key handling.

comment:6 Changed 4 years ago by andrew_b

  • Priority changed from blocker to major
  • Milestone set to Future Releases

comment:7 Changed 4 years ago by zaytsev

I think right key == enter for this windows can be brought back for Lynx-motion mode only, andrew_b, how about that? In this mode right is consistently used to change to directories...

Note: See TracTickets for help on using tickets.