Ticket #318 (closed enhancement: fixed)

Opened 10 years ago

Last modified 10 years ago

ALT+arrows mark vertical block in mcedit

Reported by: angel_il Owned by: angel_il
Priority: trivial Milestone: 4.7
Component: mcedit Version: master
Keywords: commited-master Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description

ALT+arrows mark vertical block in mcedit

Attachments

xterm-esc-seqs.patch (3.0 KB) - added by andrew_b 10 years ago.
More esc sequencies for xterm

Change History

comment:1 Changed 10 years ago by angel_il

  • Status changed from new to accepted
  • Owner set to angel_il

comment:2 Changed 10 years ago by angel_il

  • Keywords review added

branch: 318_alt_selection
based_on: master

comment:3 Changed 10 years ago by angel_il

  • Status changed from accepted to assigned

comment:4 follow-up: ↓ 5 Changed 10 years ago by ossi

alt-shift-arrow seems more appropriate. alt-arrow often has other functions (have you tried a linux console? ;).

comment:5 in reply to: ↑ 4 Changed 10 years ago by angel_il

Replying to ossi:

alt-shift-arrow seems more appropriate. alt-arrow often has other functions (have you tried a linux console? ;).

sorry i foget this :) im add "if" for console type.

Changed 10 years ago by andrew_b

More esc sequencies for xterm

comment:6 Changed 10 years ago by ossi

the linux console is just an example. it is completely reasonable to configure kde's konsole to use alt-arrow for tab switching, exactly because it is about the same as linux' vt switching.
other than that, it is not particularly sensible to make the behavior environment-specific without need.

comment:7 Changed 10 years ago by angel_il

hmm... btw it's no problem xterm users. :)
if you want use vertical selection in "konsole"
a) change hotkeys in konsole (if it possible)
b) offer your the variant maybe (Alt+Shift+arrows)
c) not use alt+arrows for vertical selection :) (no good variant)

But I use "xterm" and "putty" and I very much like to use alt+arrrows.
This patch not broke mc though konsole or console.

comment:8 follow-up: ↓ 10 Changed 10 years ago by ossi

konsole is braindead enough to have shift-arrows for tab switching by default. alt-arrows is a modification to setup a remotely sensible environment for mc and other full-screen apps.

it doesn't matter that xterm users are not affected, as linux console users *are* affected and they probably pose a significant fraction of the mc user base. and as i explained before, having environment-specific behavior for no reason is bogus.

shift-arrows means "conventional" selection (shift) by motion (arrows). it is just logical to make alt-shift-arrow mean "alternative" (alt) selection (shift) by motion (arrows). just alt-arrow doesn't have the "selection" notion and is thus better suited for other functions, like tab/document switching, history navigation, etc.

and i really have to wonder what your problem with alt-shift is. at least my hands are in an identical position, whether i press alt or alt-shift.

comment:9 Changed 10 years ago by angel_il

  • Status changed from assigned to accepted

comment:10 in reply to: ↑ 8 Changed 10 years ago by angel_il

Replying to ossi:

and i really have to wonder what your problem with alt-shift is. at least my hands are in an identical position, whether i press alt or alt-shift.

i think it's no bad idea, i try this esc sequences too for select vertical block.

comment:11 Changed 10 years ago by styx

  • Keywords vote-styx added

I think, this should be removed after intorducing key shortcuts managment/bindings

comment:12 Changed 10 years ago by angel_il

branch: 318_alt_arrows_select_block (parrent:master)
changeset: f4844e5b21c912bb7c478082e4cdb7a6082cd0a0

comment:13 Changed 10 years ago by andrew_b

  • Keywords vote-andrew_b approved added; review removed
  • Version changed from 4.6.2 to master

comment:14 Changed 10 years ago by angel_il

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:15 Changed 10 years ago by angel_il

  • Keywords commited-master added; vote-styx vote-andrew_b approved removed
  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.