Ticket #3172 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

ScreenList broken

Reported by: szaszg Owned by: andrew_b
Priority: critical Milestone: 4.8.12
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

ScreenList broken in current git source.
If we ask a screen list, we get an empt one with GLib errors (see below).

I attach a patch to fix this bug (lib/widget/listbox.c).

│/m4.include        │   4096│drwxr-xr-x││/po              │   4096│Feb 17 11:00│
│/maint                                                                17 11:00│`
│/misc         ┌────────────────────── Screens ──────────────────────┐ 17 10:52│
│/po           │                                                     │ 17 10:52│
│/src          └─────────────────────────────────────────────────────┘ 17 10:52│
│/tests                                                                17 10:52│
│ .gitattributes    │     14│-rw-r--r--││@README          │     10│Feb 17 10:52│
├──────────────────────────────────────┤├──────────────────────────────────────┤
│UP--DIR                               ││UP--DIR                               │
└──────────────────── 194G/428G (45%) ─┘└──────────────────── 194G/428G (45%) ─┘
Hint: To mark directories on the select dialog box, append a slash.
gergely@stork:~$                                                             [^]
 1Help   2Menu   (mc:15628): GLib-CRITICAL **: g_queue_insert_before: assertion `sibling != NULL' failed`

Attachments

listbox.diff (453 bytes) - added by szaszg 6 years ago.

Change History

Changed 6 years ago by szaszg

comment:1 Changed 6 years ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Milestone set to 4.8.12

Applied. Thanks!

Branch: 3172_listbox_append_item_fix
changeset:2b6e440597c9f547e17241fdc48aba2e64d1851f

comment:2 Changed 6 years ago by andrew_b

  • Branch state changed from no branch to on review

comment:3 Changed 6 years ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

comment:4 Changed 6 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

comment:5 Changed 6 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.