Ticket #3161 (closed defect: fixed)

Opened 6 years ago

Last modified 4 years ago

Faulty color when "Find file" finishes

Reported by: egmont Owned by:
Priority: trivial Milestone: 4.8.16
Component: mc-core Version: 4.8.11
Keywords: Cc:
Blocked By: Blocking: #3569
Branch state: merged Votes for changeset: committed-master

Description

Start a "Find file" operation. The first match is blue on cyan, this is the color for the selected entry of focused listboxes.

Press Tab to move the focus to one of the bottom buttons. The selected file becomes black on cyan, which is the color for the selected entry on unfocused listbox.

Wait for the "find file" operation to finish. The selected file is repainted with blue on cyan, even though the listbox is not focused. It should remain black on cyan.

Attachments

mc-3161-listbox.c-remember-focus-state.patch (2.1 KB) - added by and 4 years ago.

Change History

comment:1 Changed 4 years ago by and

when match added to find_list a WListbox object
widget_redraw() -> MSG_DRAW -> listbox_draw (l, msg != MSG_UNFOCUS)
is triggered

Currently a listbox widget will always focused on a MSG_DRAW event

to fix this flaw listbox object need a internal flag to remember focus/unfocus status
on an MSG_DRAW event it call draw correctly

Changed 4 years ago by and

comment:2 Changed 4 years ago by and

  • Milestone changed from Future Releases to 4.8.16

comment:3 Changed 4 years ago by andrew_b

  • Blocking 3569 added

comment:4 Changed 4 years ago by andrew_b

  • Status changed from new to closed
  • Component changed from mc-skin to mc-core
  • Votes for changeset set to committed-master
  • Resolution set to fixed
  • Branch state changed from no branch to merged
Note: See TracTickets for help on using tickets.