Ticket #316 (closed enhancement: fixed)

Opened 10 years ago

Last modified 10 years ago

Editor option: Persistent blocks

Reported by: angel_il Owned by: angel_il
Priority: trivial Milestone: 4.7
Component: mcedit Version: 4.6.2
Keywords: commited-master Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description (last modified by angel_il) (diff)

Need editor option "[ ] Persistent blocks", set "yes" by default.

This enable work with selected block as many editor. if option "Persistent blocks" swich on you can work with block as original mc (F5, F6, F8 block manipulation).

Change History

comment:1 Changed 10 years ago by angel_il

  • Keywords review added

branch: 316_persistent_block
based_on: master

comment:2 Changed 10 years ago by angel_il

  • Description modified (diff)

comment:3 follow-up: ↓ 5 Changed 10 years ago by ossi

the customary name is "selection", not "block".
though the "edit" menu uses "mark" currently ...

comment:4 Changed 10 years ago by slavazanko

  • Keywords vote-slavazanko added

ossi, you are right, thanks for your remark. see changeset:2390c46d06f90a4115857b436205307cdb3aaea0

Well, branch looks good. My vote here.

comment:5 in reply to: ↑ 3 Changed 10 years ago by angel_il

  • Status changed from new to assigned
  • Owner set to angel_il

Replying to ossi:

the customary name is "selection", not "block".
though the "edit" menu uses "mark" currently ...

done :)

comment:6 in reply to: ↑ description ; follow-ups: ↓ 7 ↓ 8 Changed 10 years ago by andrew_b

Replying to angel_il:

Need editor option "[ ] Persistent blocks", set "yes" by default.

Actually, defаult value is "no":

edit/edit.c:66
int option_persistent_selections = 0;

This enable work with selected block as many editor.

If this option is switched off, I can't select anything at all.

comment:7 in reply to: ↑ 6 Changed 10 years ago by angel_il

Actually, defаult value is "no":

Fixed, thx.

comment:8 in reply to: ↑ 6 Changed 10 years ago by andrew_b

  • Keywords vote-andrew_b approved added; review removed

Replying to andrew_b:

If this option is switched off, I can't select anything at all.

Ok, now it works. My vote here.

comment:9 Changed 10 years ago by angel_il

  • Status changed from assigned to testing
  • Keywords commited-master added; vote-slavazanko vote-andrew_b approved removed
  • Resolution set to fixed

comment:10 Changed 10 years ago by styx

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.