Ticket #312 (closed enhancement: fixed)

Opened 10 years ago

Last modified 10 years ago

close dialog by mouse click out of dialog area

Reported by: andrew_b Owned by: andrew_b
Priority: minor Milestone: 4.7
Component: mc-core Version: 4.6.2
Keywords: commited-master Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description

Minor UI enhancement: active dialog may be closed by single mouse click out of dialog area.

Change History

comment:1 Changed 10 years ago by andrew_b

  • Keywords review added
  • Owner set to andrew_b
  • Status changed from new to accepted

312_close_dialog_by_mouse branch is created. Parent branch: master.

comment:3 Changed 10 years ago by styx

  • Keywords vote-styx added

comment:4 Changed 10 years ago by angel_il

  • Keywords vote-angel_il added

look good

comment:5 follow-up: ↓ 6 Changed 10 years ago by angel_il

but in FAR right click work as default button. What you think about this in mc?

comment:6 in reply to: ↑ 5 Changed 10 years ago by andrew_b

Replying to angel_il:

but in FAR right click work as default button. What you think about this in mc?

Left click -- Cancel, right click -- OK. I believe I can realize such behavior.

comment:7 follow-up: ↓ 8 Changed 10 years ago by ossi

i wouldn't do such overloading of right-clicks. it is highly undiscoverable and unexpected.

comment:8 in reply to: ↑ 7 Changed 10 years ago by styx

  • Keywords vote-styx vote-angel_il removed

Replying to ossi:

i wouldn't do such overloading of right-clicks. it is highly undiscoverable and unexpected.

+1
andrew_b plans to create an option what to do or not to do with clicks.
As sources will be changed, votes are removed

comment:9 Changed 10 years ago by ossi

uh, such micro-options make config dialogs a proper nightmare. even it if is in no dialog, one should ask oneself whether it *really* makes sense to add an option.
i think it should simply resemble the behavior of modern GUIs. this essentially means that a left-click outside something with popup-behavior closes (cancels) it, while dialogs should not be affected (a simple miss-click can cause annoyance and even some minor data loss). applicable examples are menus (works already, except that the last item spans the entire free area) and drop downs.
specifically regarding the suggested right-click behavior, i can only say that it is utterly counter-intuitive - why would you click *outside* a dialog to *confirm* what is *inside* the dialog? what scenario brings you in a situation where it would be actually desirable? other than "because we can"?

comment:10 Changed 10 years ago by angel_il

this option will be turned off by default. Why it will be for you a nightmare, i dont understand.
...btw such option exists a long time in FAR and many use such behaviour of the mouse in FAR dialogs. And it is not counter-intuitive.

PS: i realy not often use it, but "i can"!

comment:11 Changed 10 years ago by ossi

configuration dialogs (and also man pages) with hundreds of options *are* a nightmare. everyone who knows something about usability will tell you that. so before introducing an option, think twice whether it really makes sense to make it optional. and when the answer is "yes", then think three times whether the feature makes sense in the first place. for counter-intuitive ui features which are inconsistent with about everything else out there (except some particular nc clone), for which no-one seems to be able to come up with a *real* use case, the answer is a very clear "no".

PS: you don't seem to have understood the "because we can" allusion. you should look up the term "feature creep" and related topics in wikipedia.

comment:12 Changed 10 years ago by angel_il

i mean "because we can" what "we can use feature" not "we can make feature".

comment:13 Changed 10 years ago by ossi

i know. and it is exactly besides the point. the question is not "could i use it once it is there", but "would i miss it if it was never there". this is called collecting uses cases, which is part of requirement engineering.

comment:14 Changed 10 years ago by angel_il

I can use mc without it :) if you so bring an attention to the question.

comment:15 Changed 10 years ago by andrew_b

Implemented option to enable/disable close dialog by mouse click outside of it: mouse_close_dialog. Disabled by default. This option is available in ini file only.

Please review changeset:8255495537b4121192e0ec94f28e2ec7d19501ff

comment:16 Changed 10 years ago by styx

  • Keywords vote-styx added

comment:17 Changed 10 years ago by slavazanko

  • Keywords vote-slavazanko approved added; review removed

looks good.

comment:18 Changed 10 years ago by andrew_b

  • Status changed from accepted to testing
  • Keywords commited-master added; vote-styx vote-slavazanko approved removed
  • Resolution set to fixed

comment:19 Changed 10 years ago by styx

  • Status changed from testing to closed

comment:21 Changed 10 years ago by andrew_b

  • severity changed from no branch to merged
Note: See TracTickets for help on using tickets.