Ticket #3119 (closed defect: fixed)
format paragraph produce inconsistent wrapping
Reported by: | onlyjob | Owned by: | andrew_b |
---|---|---|---|
Priority: | major | Milestone: | 4.8.12 |
Component: | mcedit | Version: | 4.8.11 |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Branch state: | merged | Votes for changeset: | committed-master |
Description
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=725692
Format paragraph (Alt+P) often produce strange formatting when some lines are considerably shorter than maximum line width. Also it looks like formatting sometimes stop on some characters like '*' even before the end of paragraph so when cursor is positioned just below short line with '*' pressing Alt-P re-format the paragraph down from cursor. This was found in 4.8.10 and 4.8.11. Here is sample text where problem is mildly manifesting (try re-formatting it with word-wrap-line-length=74 and see how some short lines do not change or do not change unless cursor is positioned below problematic line):
ext4* does not yet have as much support as *ext2* and *ext3* on non-Linux operating systems. *ext2* and *ext3* have stable drivers such as ext2IFS, which are not yet available for *ext4*. It is possible to create compatible *ext4* filesystems for use in Windows by disabling the extents feature, and sometimes specifying an inode size.[20] Another option for using *ext4* in Windows is to use ext2Fsd,[21] an open-source driver that, like ext2IFS, supports writing in *ext4* partitions where extents have been disabled. Viewing and copying files from *ext4* to Windows, even with extents enabled, is also possible with the ext2Read software.[22] More recently Paragon released its ExtFS for Windows which allows read/write capabilities for ext2/3/4.
Change History
comment:3 follow-up: ↓ 4 Changed 11 years ago by andrew_b
Branch: 3119_format_paragraph.
Initial changeset:27343cc163b5e39a06790d4cc64251b963d030ce
We have two independent issues here:
- Short line as in comment:1. This is a bug and it is fixed in this branch (1st commit).
- Strange formatting as described in ticket. I'm not sure there is a bug. Formatting stops if next line starts with one of the following chars (src/editor/wordproc.c:64):
#define NO_FORMAT_CHARS_START "-+*\\,.;:&>"
I don't know why that was implemented in old time. Since 1998 this behavior presents in mcedit. See https://www.midnight-commander.org/browser/edit/wordproc.c?rev=eb6b3842abd84db5e9a7695d59fb6db5c5321f4f.
comment:4 in reply to: ↑ 3 Changed 11 years ago by andrew_b
- Owner set to andrew_b
- Status changed from new to accepted
- Branch state changed from no branch to on review
- Milestone changed from Future Releases to 4.8.12
The new editor_stop_format_chars option in ~/.config/mc/ini is used now instead of hardcoded NO_FORMAT_CHARS_START.
comment:7 Changed 11 years ago by andrew_b
- Status changed from accepted to testing
- Votes for changeset changed from slavazanko to committed-master
- Resolution set to fixed
- Branch state changed from approved to merged
Merged to master: [bc2f24b0e5b19780a13e8de5ef6bc3b313c23cc5].
git log --pretty=oneline 7c7ed5e..bc2f24b
Another sample: