Ticket #3100 (accepted enhancement)

Opened 6 years ago

Last modified 5 months ago

Embedded torrent viewer/vfs

Reported by: eugenesan Owned by: slavazanko
Priority: major Milestone: Future Releases
Component: mc-vfs Version: master
Keywords: torrent ext vfs Cc:
Blocked By: Blocking:
Branch state: no branch Votes for changeset:

Description

Currently ext.d viewer for torrent is partially broken since ctorrent is used and it broken in most distributions (http://sourceforge.net/p/dtorrent/bugs/21/).

Attached patch adds viewer and vfs support based on script found here: http://phdru.name/Software/mc/torrent

Attachments

ext_embedded_torrent.patch (11.4 KB) - added by eugenesan 6 years ago.
Embed torrent viewer/vfs
add-support-for-internal-torrent-viewer-vfs.patch (16.8 KB) - added by eugenesan 6 years ago.
support kernel initrd images as VFS
0001-extfs-Add-support-for-BitTorrent-file-browse.patch (8.7 KB) - added by artemsen 5 months ago.

Change History

Changed 6 years ago by eugenesan

Embed torrent viewer/vfs

comment:1 Changed 6 years ago by slavazanko

  • Owner set to slavazanko
  • Status changed from new to accepted
  • Branch state changed from no branch to on rework

Created branch 3100_torrent
Initial changeset:10401bb70eb846261da1e51f4c6e3a751995ae8f

But branch is stayed in 'on rework' stage because have an issue with viewing .torrent files (via F3):

./torrent view some-file.torrent 
Unknown command view
Last edited 6 years ago by slavazanko (previous) (diff)

Changed 6 years ago by eugenesan

support kernel initrd images as VFS

comment:2 Changed 6 years ago by eugenesan

Fixed and refreshed the patch

comment:3 Changed 6 years ago by andrew_b

  • Milestone changed from 4.8.11 to 4.8.12

comment:4 Changed 5 years ago by andrew_b

  • Milestone changed from 4.8.12 to Future Releases

Changed 5 months ago by artemsen

comment:5 Changed 5 months ago by artemsen

  • Component changed from mc-core to mc-vfs
  • Branch state changed from on rework to on review

comment:6 follow-up: ↓ 8 Changed 5 months ago by andrew_b

Is python3 required?

comment:7 Changed 5 months ago by andrew_b

  • Branch state changed from on review to no branch

comment:8 in reply to: ↑ 6 ; follow-up: ↓ 9 Changed 5 months ago by artemsen

Replying to andrew_b:

Is python3 required?

Yes, python3 is required. Does MC have restrictions with that?

comment:9 in reply to: ↑ 8 ; follow-up: ↓ 10 Changed 5 months ago by andrew_b

Replying to artemsen:

Yes, python3 is required. Does MC have restrictions with that?

Generally no. extfs plugins written in python don't have explicit python version in shebang (#3936). Using pyhon3 explicitly can break the portability. Some systems where mc is used may not have python3.

comment:10 in reply to: ↑ 9 Changed 5 months ago by artemsen

Replying to andrew_b:

extfs plugins written in python don't have explicit python version in shebang (#3936). Using pyhon3 explicitly can break the portability.

Do you suggest to use MC's shebang that was set by configure script? I don't think it's a good idea to use /usr/bin/python because it may point to python2 as well as to python3, meanwhile the usual shebang '#!/usr/bin/env python3' is a system independent solution.

Some systems where mc is used may not have python3.

Yes, but these system may not have python2 or even bash, so...
Anyway, this plugin is not a mandatory component and it doesn't brake general MC functionality.

Note: See TracTickets for help on using tickets.