savannah: support for x clipboard wanted

[slavazanko]

Original: ​http://savannah.gnu.org/bugs/?13751

Submitted by:	Oswald Buddenhagen <ossi>	Submitted on:	Tue 12 Jul 2005 10:44:23 AM UTC
Category:	Editor	Severity:	3 - Normal
Status:	None	Privacy:	Public
Assigned to:	None	Open/Closed:	Open
Release:	current (CVS or snapshot)	Operating System:	All

Discussion:

Sun 06 Jul 2008 04:19:44 PM UTC, comment #1:
I run mc/mcedit always with the -d switch to deactivate mc's 
special mouse handling and get my X clipboard support (i.e. 
double-click to copy, middle button to paste) back.
	Jan Engelhardt <hirogen2>
Tue 12 Jul 2005 10:44:23 AM UTC, original submission:
another one from the "hey, i'm an x application" department.
when running under x, it should be possible to use the x clipboard 
instead of mc's "proprietary" clip file. there should also be an 
option to make it the default, at least for the cua keybindings 
(the ones with shift & ctrl and the cursor block). there is one 
problem with xterm, though ... it steals us the shift-ins key combo 
to do X PRIMARY selection pasting itself. so unless there is a way 
to convince xterm not to do this (or at least a way to hack around 
it), we have a problem.

[ossi]

fwiw, overriding xterm's mapping is in fact a FAQ. the solution is to add

XTerm*VT100*translations: #override \nShift <KeyPress?> Insert:insert-eight-bit()

to the ~/.Xresources file (or whatever your setup has).

iow, there is nothing to make this feature unfeasible.

[slavazanko]

I think, better to support XWindow clipboard more native - for example, pressing ALT+F (in additional) will add to Xclipboard current selection in editor...

[ossi]

Replying to slavazanko:

I think, better to support XWindow clipboard more native - for example, pressing ALT+F (in additional) will add to Xclipboard current selection in editor...

that's more explicit, but definitely not more native - quite to the contrary even, as the x clipboard is native in an x environment and can be expected to be found under the usual keybindings (that's why xterm has that keybinding in the first place). mc's own clipboard is still reachable via ctrl-f and shift-f5, so why deviate from the intuitive keybindings? one reason could be consistent access from mc instances running in consoles and in xterms at the same time. seems like a corner case which i would not want to sacrifice for better integration into the windowing environment. but that can be configurable as indicated in the original submission.

fwiw, given that you did not choose to use alt-shift-ins for vertical pasting, you could it use now to paste PRIMARY (as opposed to CLIPBOARD with shift-ins).

[xintrea]

In path "editcmd.c xclip patch for 4.7.0-pre2" memory leak be present.

In functions edit_copy_to_X_buf_cmd() and edit_cut_to_X_buf_cmd() instead code

char *tmp; 
tmp = g_strconcat ("xclip -i ",concat_dir_and_file (home_dir, EDIT_CLIP_FILE)," -selection clipboard", NULL ); 
system (tmp); 
g_free(tmp);

...must have code

    // Work with X-buffer
    char *tmp;
    gchar *concat_result=concat_dir_and_file (home_dir, EDIT_CLIP_FILE);
    tmp = g_strconcat ("xclip -i ", concat_result, " -selection clipboard", NULL );
    system (tmp);
    g_free(tmp);
    g_free(concat_result);

I don't know, how make path file, but please insert this code correction.

[uchti]

editcmd.c xclip patch for 4.7.0-pre2

[xintrea]

Oops, solving for copy to X-buffer with "xclip" have any problem.

If system locale i.e. KOI-8R, and text file in other codepage (i.e. UTF-8), we select by Ctrl+T UTF-8 codepage. In "copy to X-buffer action", in cooledit.clip file putted text in UTF-8 codepade. Next, running command

xlib -i cooledit.clip

and in buffer inserting UTF-8 text. If paste from buffer this text into MC or into any text editor, we seen bad cyrillic symbol.

Solved this problem - convert cooledit.clip (before run xlib) from editor codepage to system codepage.

For write code, need known:

How get editor codepage as string, i.e. "UTF-8"?
How get system codepage as string, i.e. "KOI-8R"?

[iNode]

Use enca, Luke.

[angel_il]

How get editor codepage as string, i.e. "UTF-8"?
How get system codepage as string, i.e. "KOI-8R"?

use "get_codepage_id (source_codepage)"

[xintrea]

Replying to angel_il:

How get editor codepage as string, i.e. "UTF-8"?
How get system codepage as string, i.e. "KOI-8R"?

use "get_codepage_id (source_codepage)"

Im jumble.

Index "source_codepage" - it is current editor codepage?
Index "display_codepage" - it is system codepage?

[xintrea]

This is bullshit. The official version of xclip uncorrect work with national (cyrillic) symbols.

Prooflink for russian people - ​http://habrahabr.ru/blogs/linux/48954/

If locale is KOI-8R, and in cooledit.clip put text in KOI-8R, then after command

xclip -i cooledit.clip -selection clipboard

in clipbord put text with bad cyrillic symbols.

What is to do?

[angel_il]

branch: 30_external_clipboard_utility
changeset: a176c37b8460bd326f6dc7cabce576fccc894ded

please review :)

[angel_il]

branch: 30_external_clipboard_utility (forced update)
changeset: a5fd5ce88c130d6bc4b4061cfc8f4a4536e96ba1

[angel_il]

Merged: 781706ef9c0329e499450da9ce050ee487c60770