Dropdown menu is not centered

[egmont]

F9 -> Left (or File, Command, Right)

The dropdown menu's content isn't centered, it has a space on the left but not on the right, e.g.
| Quick view C-x q|
Notice there's a space before "Quick view", but not after "C-x q".

F9 -> Options

One space on the left, two spaces on the right.

[egmont]

fix

[egmont]

Notes:

max_hotkey_len was incorrectly named, it's the length of the text label, not the hotkey. I just renamed the variable and fixed the comment, didn't change the behavior here.

max_entry_len contained the length without the two spaces between the text labels and the shortcut. Now it includes these two spaces too, unless no shortcuts are used.

The mouse x coordinates were a bit off, usually the left border was also valid but the right border wasn't, unless the menu was pushed to the left because of a narrow terminal, in which case the right border belonged to the entry and the left didn't. I've fixed it so that neither of them belongs to the menu entry anymore.

[andrew_b]

Replying to egmont:

F9 -> Left (or File, Command, Right)

The dropdown menu's content isn't centered, it has a space on the left but not on the right, e.g.
| Quick view C-x q|

The left one-symbol space is matched with menu_entry_t::first_letter. Currently it's unused (seems it wasn't used ever). Probably it can be useful in the future to mark active menu item. For example:

▕ ✓File listing          ▕
▕  Quick view       C-x q▕
▕  Info             C-x i▕
▕  Tree                  ▕

▕  File listing          ▕
▕  Quick view       C-x q▕
▕ ✓Info             C-x i▕
▕  Tree                  ▕

But currently menu doesn't support checked items and I think we just can remove the menu_entry_t::first_letter field.

[egmont]

Good point. Looks the menus of graphical menus is often uncentered too for the same reason.
Feel free to close as invalid/wontfix if you wish.