mc under x11 problems with mouse or hang due gpm

[acobar]

mc may not detect the gpm mouse under X11 on many x terminals when running together with tmux or screen.

On some cases it can even hang.

I sent a small patch to the gpm maintainer to improve its checking. Seems there is a need also to a small change on mc.

Now everything is working perfectly.

[acobar]

mc gpm x terminal improvments

[acobar]

gpm counterpart patch

[slavazanko]

Will it works as it worked before (without your patch which you sent to GPM devteam)? Have we backward compatibility or will be new unexpected behavior here?

[acobar]

Replying to slavazanko:

Will it works as it worked before (without your patch which you sent to GPM devteam)? Have we backward compatibility or will be new unexpected behavior here?

From what I gathered, gpm, once it does not recognize an x terminal, assumes it is probably running on console so some race condition with X input is triggered and the hangs that people complain show up at random.

When gpm does recognize an x terminal, it returns -2 from Gpm_Open, what is a valid interpretation for it, but can not be used with select. I assume that gpm then does send mouse actions translation to keyboard input buffer though, as they are properly processed by mc after the patches.

Answering your question, I noted no regression with my patches to mc (nor on X nor on 'pure' console), but yes, I think that it is needed to patch gpm as the problem we were experiencing were related to the behavior of both, even though the segfaults where on gpm side.

The only thing I did not check was putty terminal, what I will probably tomorrow.

Best regards,
André

[slavazanko]

From patch:

+                /** Need more information first
+                const char *xdisplay;
+
+                if ((xdisplay = getenv ("DISPLAY")) != NULL && *xdisplay == '\0')
+                    xdisplay = NULL;
+                */

Is this comment needed?

[acobar]

Replying to slavazanko:

From patch:

+                /** Need more information first
+                const char *xdisplay;
+
+                if ((xdisplay = getenv ("DISPLAY")) != NULL && *xdisplay == '\0')
+                    xdisplay = NULL;
+                */

Is this comment needed?

Right now it is not needed. I will probably make more tests on how mc process mouse inputs soon, that is why I left the comment there, to remember.

[slavazanko]

Created branch 3011_mc_gpm_and_xterm
Initial changeset:ff5e5487228e74b2f9d9f7efd2ca29a305e085c8

Review, please.

[slavazanko]

Merged to master.

git log --pretty=oneline ffc536f..9699d5d