Ticket #3010 (new defect)

Opened 5 years ago

Last modified 2 years ago

subshell is not working with dash

Reported by: god12 Owned by:
Priority: major Milestone: Future Releases
Component: mc-core Version: 4.8.15
Keywords: Cc: pahan@…
Blocked By: #3692 Blocking:
Branch state: no branch Votes for changeset:

Description

if root uses dash as a default login shell than mc is unable to engage subshell (ctrl+o) with error message about not xterm or linux console.

Note: I can run dash as regular user and mc works just fine in it, but "sudo mc" gives the error described above. If root's default login shell is switched to bash than 'sudo mc' works as expected.

Change History

comment:1 Changed 5 years ago by andrew_b

  • Blocked By 2742 added

comment:2 Changed 5 years ago by god12

Note to self: patch to fix this probably available in #2742

comment:3 Changed 4 years ago by god12

  • Version changed from 4.8.8 to 4.8.13

mc 4.8.13

There's no error message anymore but shell prompt is not displayed after ctrl+o and if I press any key mc panels are back as if I've pressed ctrl+o again.

So it's still completely broken.

comment:4 Changed 4 years ago by Hubbitus

  • Cc pahan@… added

comment:5 Changed 3 years ago by god12

  • Version changed from 4.8.13 to 4.8.15

Still the case with 4.8.15

comment:6 Changed 3 years ago by slavazanko

  • Blocked By 2742 removed

(In #2742) merged into master:

git log --pretty=oneline 2e651d0..0d6d1d0

comment:7 Changed 3 years ago by and

I can confirm this root-dash-mc-subshell bug in 4.8.15
which is resolved in current git version.

comment:8 Changed 3 years ago by and

  • Milestone changed from Future Releases to 4.8.16

comment:9 Changed 3 years ago by andrew_b

  • Milestone changed from 4.8.16 to Future Releases

@and please don't change milestone.

comment:10 Changed 3 years ago by and

ok, andrew

comment:11 follow-up: ↓ 13 Changed 3 years ago by zaytsev

@andrew_b, so shall we close this as a duplicate of #2742?

comment:12 Changed 3 years ago by zaytsev

@andrew_b, also, regarding milestones, see my suggestion in #2707.

comment:13 in reply to: ↑ 11 Changed 3 years ago by andrew_b

Replying to zaytsev:

@andrew_b, so shall we close this as a duplicate of #2742?

I don't know. I don't use dash.

comment:14 Changed 3 years ago by zaytsev

Ok, I've checked it with 4.8.15 and current master (4.8.15-218-g4d5c1b2). With 4.8.15 it doesn't work at all, that is, subshell support is completely deactivated. With current master it works to a degree (subshell support is initialized, running commands in prompt works, CTRL+O works).

However, there is still an annoying a bug. When one switches from panels to console with CTRL+O, ^H (literally) is printed to the prompt. Many switches back and forth result in more ^H. They can be simply deleted by hand, but otherwise cause errors when running commands. Tested on dash 0.5.5.1, can't try a newer one for now.

@and, you're saying it works for you, can you reproduce the ^H issue, if not, which version of dash have you used for testing?

comment:15 Changed 3 years ago by and

I have simple tested, no in deep testing because I not a dash lover.
In 4.8.15 no subshell was here, in current master subshell was testing by simple commands.

comment:16 Changed 2 years ago by andrew_b

  • Blocked By 3692 added
Note: See TracTickets for help on using tickets.