Copy/move dialog report invalid file size when file already exist.

[gv]

# mkdir src
# mkdir dst
# cp test.txt src/test.txt
# cp test.txt dst/test.txt
# ls -l src/test.txt dst/test.txt
-rw-r--r--. 1 gabriel gabriel 1093 Apr 8 19:13 dst/test.txt
-rw-r--r--. 1 gabriel gabriel 1093 Apr 8 19:13 src/test.txt
# mc
left panel : src
right panel: dst
Try to copy/move test.txt from src over test.txt in dst

[File exists]
[Target file already exists!"]
[~/dst/test.txt]
[New : Apr 8 19:13, size 1093K]
[Existing: Apr 8 19:13, size 1093K]

File size is 1093 bytes not 1093 kbytes.

If file is 3716886 bytes copy/rename dialog report 3716886M.
If file is 1194181320 bytes copy/rename dialog report 1194181320G.

[gv]

Patch

[andrew_b]

I can't agree with this patch. If you get the "Target file already exists!" error for huge file (many GBs), the size in bytes can exceed the bounds of dialog area.

[gv]

It would be nice when you overwrite a file (even if it is very large) to see the size in bytes.

Anyway, patch does not work well when panels_options.kilobyte_si is on.

[gv]

Sorry, It does work.
Anyway, it's up to you to find a better solution. It's fine for me and I'm going to use-it.

[gv]

# xterm -fn 10x20

┌───────────────────── File exists ──────────────────────┐
│ Target file already exists! │
│ /saves/gabriel/Fedora-18-x86_64-DVD.iso │
├────────────────────────────────────────────────────────┤
│ New : Jan 9 23:01, size 4573888512 │
│ Existing: Jan 9 23:01, size 4573888512 │

# xterm -fn 7x14

│ New : Jan 9 23:01, size 4573888512G │
│ Existing: Jan 9 23:01, size 4573888512G │

Same amount of space in standard linux console terminal.

So, from my point of view, there is plenty of space. Even for very large files.
But again, it's up to you.

[gv]

# echo -n "4573888512 " | wc -c
25

(25 even in standard linux text console)
maximum value of uintmax_t: 18447644073710439615 (util.c line 444)

# echo -n 18447644073710439615 | wc -c
20

So how exactly "the size in bytes can exceed the bounds of dialog area"?
:-)

[andrew_b]

Ok, I reverted wrong modification of size_trunc_len() and restored previous size format.

Branch: 3000_incorrect_filesize
Initial changeset:4d140433700806203c8a9a6478af47f4f42424c8

[onlyjob]

Changeset is good -- it works as expected.

IMHO for comparison it is important that dialog shows size of files exactly in bytes.
No further "optimisation" (to add K/M/G) is necessary.

Thanks.

[andrew_b]

Merged to master: [7332b3558415a9b17b0bb73854a4278c1fb23a95].

git log --pretty=oneline 6b64835..7332b35