mc fails to link when system lib does not contain strverscmp

[zyxmon]

The fix is very simple and obvious.
It is in the attachment.

(I was crosscompiling mc-4.8.8 for a mips router with uclibc0.9.30.3)

[zyxmon]

patch to fix an issue

[slavazanko]

Created branch 2992_strverscmp
Initial changeset:21ad110e66907c5e99d3a2675f971df80c88defb

Review, please.

[er13]

Hi,

wanted to report the same issue but found this ticket before.

The fix from ​21ad110e66 is not incorrect but it's a bit strange. str_verscmp (with underscore) is your own replacement for libc (actually glibc) function strverscmp (without underscore). There exists and there never existed function called str_verscmp in any libc implementation. So there is no need to check for it in ​configure. There is also no need to change anything in ​lib/strutil/strverscmp.c. defined(HAVE_STR_VERSCMP) will never evaluate to true so it's just a dead-code.

Even if we would assume there are systems out there providing str_verscmp the change in ​lib/strutil/strverscmp.c is incorrect. On such systems the implementation will end up with a recursive end-less call to itself, this ​view makes it more evident.

Best,
Gene

[andrew_b]

All commits in the branch starting with changeset:21ad110e66907c5e99d3a2675f971df80c88defb will be squashed.

[slavazanko]

Merged to master:

git log --pretty=oneline 86fc45d..0013ade
}}