Ticket #2964 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

mouse does not work in subshell on linux terminal

Reported by: gilhad Owned by: andrew_b
Priority: major Milestone: 4.8.8
Component: mc-tty Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

I am using Gentoo, I reported that to Gentoo team, they sugested to report to upsream. I emerged mc, did not start X, just started mc. Ctrl-O to see the black screen, click left mouse and drag to select text - mouse do not move. Release mouse, cursor jumps to new position, but text is not selected and not in clipboard.

run mc under terminal on X, Ctrl-O to see the black screen, click left mouse and drag to select text - mouse selects the text, text could be pasted by middle mouse click.

kill X, run mc on text screen, the problem is back again. Run 'TERM=xrvt mc' the mouse can select text on the text screen (but command line is on top of previus text and so as it is bad terminal type)

I just tested that only on framebuffer (term=linux) (as i use more lines/char per line and nice tuxes on start)

Reproducible: Always

Steps to Reproduce:

  1. run mc in text mode
  2. Ctrl+O to subshell
  3. Try select anything with mouse

Actual Results:
mouse do not select anything

Expected Results:
mouse works like without mc (selects, paste ...)

Happenes on more computers, on more versions of mc.

mc -V

GNU Midnight Commander 4.8.1
Built with GLib 2.30.2
Using the ncurses library
With builtin Editor
With subshell support as default
With support for background operations
With mouse support on xterm and Linux console
With support for X11 events
With internationalization support
With multiple codepages support
Virtual File Systems: cpiofs, tarfs, sfs, extfs, ext2undelfs, ftpfs, fish
Data types: char: 8; int: 32; long: 32; void *: 32; size_t: 32; off_t: 64;

mc -F

[System data]

Config directory: /etc/mc/
Data directory: /usr/share/mc/
VFS plugins and scripts: /usr/libexec/mc/

extfs.d: /usr/libexec/mc/extfs.d/
fish: /usr/libexec/mc/fish/

[User data]

Config directory: /home/gilhad/.mc/
Data directory: /home/gilhad/.mc/

skins: /home/gilhad/.mc/skins/
extfs.d: /home/gilhad/.mc/extfs.d/
fish: /home/gilhad/.mc/fish/

Cache directory: /home/gilhad/.mc/

Change History

comment:2 Changed 6 years ago by andrew_b

  • Component changed from mc-core to mc-tty

comment:3 Changed 6 years ago by andrew_b

This bug was introduced in #2601: [68468a25acea04c44320d0a75226a051d7c2b64a].

comment:4 follow-up: ↓ 5 Changed 6 years ago by gilhad

So, would be possible to add linux term there too? I tried it on my computer and it looks working for me:

--- lib/tty/tty.c.old	2013-02-07 21:10:16.000000000 +0100
+++ lib/tty/tty.c	2013-02-07 21:06:32.000000000 +0100
@@ -101,6 +101,7 @@
     return force_xterm || strncmp (termvalue, "xterm", 5) == 0
         || strncmp (termvalue, "konsole", 7) == 0
         || strncmp (termvalue, "rxvt", 4) == 0
+        || strncmp (termvalue, "linux", 5) == 0
         || strcmp (termvalue, "Eterm") == 0 || strcmp (termvalue, "dtterm") == 0;
 }

comment:5 in reply to: ↑ 4 Changed 6 years ago by andrew_b

Replying to gilhad:

So, would be possible to add linux term there too?

It is possible if GPM is working in Linux only. If GPM supports other OSes, this solution is not very well.

Version 0, edited 6 years ago by andrew_b (next)

comment:6 Changed 6 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.8

Branch: 2964_mouse_in_subshell.
changeset:a98622439d39c83264ed58898cf531f9e43ad24e

comment:7 Changed 6 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:8 Changed 6 years ago by angel_il

  • Votes for changeset changed from slavazanko to slavazanko angel_il
  • Branch state changed from on review to approved

comment:9 Changed 6 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from slavazanko angel_il to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

comment:10 Changed 6 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.