Ticket #2926 (closed defect: fixed)

Opened 12 years ago

Last modified 12 years ago

[PATCH] fix --with-ncurses-libs

Reported by: and Owned by: andrew_b
Priority: minor Milestone: 4.8.7
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master committed-stable

Description

if using external ncurses with
#./configure --with-ncurses-inc=... --with-ncurses-libs=...
it failed with:
configure: error: Cannot find ncurses library

because --with-ncurses-libs is not proper evaluated.

Attached patch will fix it.

Attachments

mc-4.8.6_with-ncurses-libs.patch​ (897 bytes) - added by and 12 years ago.
patch agains 4.8.6 configure and m4.include/mc-with-screen-ncurses.m4

Change History

Changed 12 years ago by and

patch agains 4.8.6 configure and m4.include/mc-with-screen-ncurses.m4

comment:1 Changed 12 years ago by andrew_b

Unfortunately, patch is not correct. CPPFLAGS is not proper place for libs. LDFLAGS should be used for.

comment:2 Changed 12 years ago by andrew_b

  • Owner set to andrew_b
  • Keywords stable-candidate added; with-ncurses-libs removed
  • Status changed from new to accepted
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.7

Branch: 2926_screen_lib_flags (parent: master).
Initial changeset:f2dea328908b5cc8e134cc748744372e992646e1

comment:3 Changed 12 years ago by angel_il

  • Votes for changeset set to angel_il

comment:4 Changed 12 years ago by slavazanko

  • Votes for changeset changed from angel_il to angel_il slavazanko
  • Branch state changed from on review to approved

comment:5 Changed 12 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from angel_il slavazanko to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [177f1dc5ba2c65ccadb93c8b7bb5fec37e29df48].

git log --pretty=oneline f0d1d91..177f1dc

comment:6 Changed 12 years ago by andrew_b

  • Status changed from testing to closed
  • Keywords stable-candidate removed
  • Votes for changeset changed from committed-master to committed-master committed-stable

Merged to 4.8.1-stable: [c8af535907848b6dad76437566e1fc9b2768c109].

git log --pretty=oneline 65569af..c8af535
Note: See TracTickets for help on using tickets.