Ticket #2918 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

cygwin test build failure

Reported by: matzeri Owned by: andrew_b
Priority: major Milestone: 4.8.7
Component: tests Version: 4.8.1.6
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master committed-stable

Description

on
tests/lib/mcconfig/Makefile.am
tests/lib/vfs/Makefile.am
tests/src/filemanager/Makefile.am

AM_LDFLAGS = -Wl,-z,muldefs

but on cygwin the linker does not accept the "-z" option and

AM_LDFLAGS = -Wl,--allow-multiple-definition

is needed.

Attachments

2918_cygwin_muldefs.diff (2.0 KB) - added by andrew_b 6 years ago.

Change History

Changed 6 years ago by andrew_b

comment:1 Changed 6 years ago by andrew_b

Please test the attached patch.

comment:2 Changed 6 years ago by matzeri

it is OK.

$ grep -i pass mc-4.8.1.6-1-check.log
PASS: library_independ.exe
PASS: mc_build_filename.exe
PASS: serialize.exe
PASS: x_basename.exe
All 4 tests passed
PASS: config_string.exe
PASS: user_configs_path.exe
All 2 tests passed
PASS: regex_replace_esc_seq.exe
PASS: regex_process_escape_sequence.exe
All 2 tests passed
PASS: canonicalize_pathname.exe
PASS: current_dir.exe
PASS: path_cmp.exe
PASS: path_len.exe
PASS: path_manipulations.exe
PASS: path_serialize.exe
PASS: relative_cd.exe
PASS: tempdir.exe
PASS: vfs_parse_ls_lga.exe
PASS: vfs_path_string_convert.exe
PASS: vfs_prefix_to_class.exe
PASS: vfs_split.exe
PASS: vfs_s_get_path.exe
PASS: path_recode.exe
All 14 tests passed
PASS: do_panel_cd.exe
PASS: examine_cd.exe
All 2 tests passed

comment:3 Changed 6 years ago by slavazanko

  • Owner set to slavazanko
  • Status changed from new to accepted
  • Votes for changeset set to slavazanko

Created branch 2918_cygwin_test_build (parent: master).
changeset:fe7ec790fcaadd3faf1ece5ec8bc8dd71647e0e0

Review, please.

Last edited 6 years ago by andrew_b (previous) (diff)

comment:4 Changed 6 years ago by andrew_b

  • Milestone changed from Future Releases to 4.8.7

comment:5 Changed 6 years ago by andrew_b

  • Owner changed from slavazanko to andrew_b
  • Keywords stable-candidate added

comment:6 Changed 6 years ago by andrew_b

  • Branch state changed from no branch to on review

comment:7 Changed 6 years ago by angel_il

  • Votes for changeset changed from slavazanko to slavazanko angel_il
  • Branch state changed from on review to approved

comment:8 Changed 6 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from slavazanko angel_il to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

comment:9 Changed 6 years ago by andrew_b

  • Keywords stable-candidate removed
  • Status changed from testing to closed
  • Votes for changeset changed from committed-master to committed-master committed-stable
Note: See TracTickets for help on using tickets.