4.8.x subshell input line is limited to 80 characters, and is overwritten when filled instead of continuing on the next line

[drookie]

Subshell input line is limited to 80 characters, and is overwritten when filled instead of continuing on the next line.

Uname:

# uname -a
SunOS anthe 5.11 11.0 i86pc i386 i86pc

Info:

# /usr/local/mc-4.8.6/bin/mc -V
GNU Midnight Commander 4.8.6
Built with GLib 2.28.6
Using the S-Lang library with terminfo database
With builtin Editor
With subshell support as default
With support for background operations
With mouse support on xterm
With support for X11 events
With internationalization support
With multiple codepages support
Virtual File Systems: cpiofs, tarfs, sfs, extfs, ftpfs, fish
Data types: char: 8; int: 32; long: 64; void *: 64; size_t: 64; off_t: 64;

I attached the screenshot demonstrating the issue:

• the first sequence of 'x' characters is typed in the subshell of the MC 4.7.5.2. When the line is filled, subshell continues typing on the next line.

• the second sequence of the 'x' chacacters is typed under the subshell of the 4.8.6 version. When the chacacter reaches the 80th position (however, the terminal has 120x45 geometry) the input line is overwritten (the cursor replaces the subshell prompt) and the whole thing is looped (the line is overwritten again and again).

[andrew_b]

Replying to drookie:

I attached the screenshot demonstrating the issue:

Looks like Putty on Windows.

When the chacacter reaches the 80th position (however, the terminal has 120x45 geometry) the input line is overwritten.

Show the result of command

echo $LINES $COLUMNS

[drookie]

Replying to andrew_b:

Replying to drookie:

I attached the screenshot demonstrating the issue:

Looks like Putty on Windows.

Yup ! It is.

Show the result of command

echo $LINES $COLUMNS

(pure bash)
[root@anthe ~]# echo $LINES $COLUMNS
44 130
(mc 4.8.6 subshell)
[root@anthe ~]# /usr/local/mc-4.8.6/bin/mc
[root@anthe ~]# echo $LINES $COLUMNS
65 80
(mc 4.5.2 subshell)
[root@anthe ~]# /usr/local/mc/bin/mc
[root@anthe ~]# echo $LINES $COLUMNS
44 130

[drookie]

Please excuse me, I was wrong about 120x45. It is indeed 130x44, bash and the 4.7.5.2 subshell report its geometry correctly, 4.8.6 subshell - does not.

[andrew_b]

The main difference I've found between 4.7.5.x and 4.8.x branches is SIWGINCH handler setup: in 4.7.5.x after subshel init, in 4.8.x before one. I created a patch that reverts SIWGINCH handler setup in 4.8.x. Could you please test it?

[drookie]

Sure.

I applied the patch to the DEV branch you gave me in #2906.
I applied the patch, redid the gmake (to my knowledge, it should rebuild only the changed files and all of their dependencies) and launched the newly built binary. All went fine without any error.

From what I see, it seems like nothing changed: the input line is still overwriting, the subshell reports wrong geometry.

[drookie]

By the way, I tested if this is somehow related to the putty - I can say I can reproduce the bug under the KDE 4.8.4 konsole - FreeBSD 9.1-PRERELEASE, when I use the FreeBSD ssh to log in to the target machine mentioned above.

[drookie]

Still there in 4.8.8.

[drookie]

FreeBSD has the 4.8.1.4 version in ports with local patches. I've tried this version on solaris, even with one patch (others were looking like they definitely have nothing to do with a problem), but this is still reproducible. While on FreeBSD it's not.
Weird !

[drookie]

Still there in 4.8.12.

[zaytsev]

[zaytsev@freebsd ~]$ uname -a
FreeBSD freebsd 14.1-RELEASE-p5 FreeBSD 14.1-RELEASE-p5 GENERIC arm64

Not reproducible with latest master.

Oracle Solaris 11.4.42.111.0                  Assembled December 2021
root@solaris:~# uname -a
SunOS solaris 5.11 11.4.42.111.0 i86pc i386 i86pc non-virtualized

test@solaris:~$ mc -V
GNU Midnight Commander 4.8.13
Built with GLib 2.28.6
Using the S-Lang library with terminfo database
With builtin Editor
With subshell support as default
With support for background operations
With mouse support on xterm
With support for X11 events
With internationalization support
With multiple codepages support
Virtual File Systems: cpiofs, tarfs, sfs, extfs, ftpfs, fish
Data types: char: 8; int: 32; long: 64; void *: 64; size_t: 64; off_t: 64;

Reproducible with 4.8.13, but not with the latest master.

Bugs fix themselves if you wait enough years :)

[zaytsev]

Apparently fixed in #4099.