Ticket #2777 (closed defect: fixed)

Opened 8 years ago

Last modified 8 years ago

Stale symlinks in vfs

Reported by: andrew_b Owned by: slavazanko
Priority: major Milestone: 4.8.3
Component: mc-vfs Version: 4.8.2
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master committed-stable

Description

How to reproduce:

  1. Create any temporary dir
  2. cd to this temporary dir
  1. Create two archives:
      mkdir -p a/b
      touch a/b/d
      ln -s d a/b/e
      tar -cf good.tar a
      rm -rf a
      mkdir -p a/b/c
      touch a/b/c/d
      ln -s d a/b/c/e
      tar -cf bad.tar a
      rm -rf a
    
  1. Enter to the good.tar and cd to a/b. Symlink e points to d and it is not stale.
  2. Enter to the bad.tar and cd to a/b/c. Symlink e points to d and it is stale.

The difference between that symlinks is a deep where symlink is. The deep of 2 or less directories is ok, symlinks are not stale. The deep of 3 or more directories is not ok, symlinks are stale.

Bisect told that first bad commit is [e2c326997f703ca111a7d3e079c12c26aeaddcbe].

Change History

comment:1 Changed 8 years ago by slavazanko

  • Owner set to slavazanko
  • Status changed from new to accepted
  • Keywords stable-candidate added
  • Blocking 2695 added
  • Branch state changed from no branch to on review

created branch 2777_vfs_stale_symlinks

Review, please.

comment:2 Changed 8 years ago by andrew_b

  • Votes for changeset set to andrew_b

comment:3 Changed 8 years ago by angel_il

  • Votes for changeset changed from andrew_b to andrew_b angel_il
  • Branch state changed from on review to approved

comment:4 Changed 8 years ago by slavazanko

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b angel_il to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master:

git log --pretty=oneline 876e006..33ea909

comment:5 Changed 8 years ago by slavazanko

  • Status changed from testing to closed
  • Keywords stable-candidate removed
  • Blocking 2695 removed

Also merged to stable

comment:6 Changed 8 years ago by slavazanko

  • Votes for changeset changed from committed-master to committed-master committed-stable
Note: See TracTickets for help on using tickets.